Re: [PATCH] mm/sparse: Make sparse_init_one_section void and remove check

2018-07-06 Thread Ross Zwisler
On Mon, Jul 2, 2018 at 12:48 PM Pavel Tatashin wrote: > > On Mon, Jul 2, 2018 at 11:43 AM wrote: > > > > From: Oscar Salvador > > > > sparse_init_one_section() is being called from two sites: > > sparse_init() and sparse_add_one_section(). > > The former calls it from a for_each_present_section_

Re: [PATCH] mm/sparse: Make sparse_init_one_section void and remove check

2018-07-02 Thread Pavel Tatashin
On Mon, Jul 2, 2018 at 11:43 AM wrote: > > From: Oscar Salvador > > sparse_init_one_section() is being called from two sites: > sparse_init() and sparse_add_one_section(). > The former calls it from a for_each_present_section_nr() loop, > and the latter marks the section as present before calling

Re: [PATCH] mm/sparse: Make sparse_init_one_section void and remove check

2018-07-02 Thread Michal Hocko
On Mon 02-07-18 17:43:25, osalva...@techadventures.net wrote: > From: Oscar Salvador > > sparse_init_one_section() is being called from two sites: > sparse_init() and sparse_add_one_section(). > The former calls it from a for_each_present_section_nr() loop, > and the latter marks the section as p

[PATCH] mm/sparse: Make sparse_init_one_section void and remove check

2018-07-02 Thread osalvador
From: Oscar Salvador sparse_init_one_section() is being called from two sites: sparse_init() and sparse_add_one_section(). The former calls it from a for_each_present_section_nr() loop, and the latter marks the section as present before calling it. This means that when sparse_init_one_section() g