Re: [PATCH] mm/slob: avoid type warning about alignment value

2012-07-11 Thread David Rientjes
On Wed, 11 Jul 2012, Arnd Bergmann wrote: > Also, size_t seems to be the correct type here, while the untyped > definition is just an int. > Ok, sounds good, thanks. Acked-by: David Rientjes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] mm/slob: avoid type warning about alignment value

2012-07-10 Thread Arnd Bergmann
On Wednesday 11 July 2012, David Rientjes wrote: > Wouldn't it be better to avoid this problem more generally by casting the > __alignof__ for ARCH_{KMALLOC,SLAB}_MINALIGN to int in slab.h? All > architectures that define these themselves will be using plain integers, > the problem is __alignof

Re: [PATCH] mm/slob: avoid type warning about alignment value

2012-07-10 Thread David Rientjes
On Tue, 10 Jul 2012, Arnd Bergmann wrote: > diff --git a/mm/slob.c b/mm/slob.c > index 95d1c7d..51d6a27 100644 > --- a/mm/slob.c > +++ b/mm/slob.c > @@ -426,7 +426,7 @@ out: > void *__kmalloc_node(size_t size, gfp_t gfp, int node) > { > unsigned int *m; > - int align = max(ARCH_KMALLOC

[PATCH] mm/slob: avoid type warning about alignment value

2012-07-10 Thread Arnd Bergmann
The types for ARCH_KMALLOC_MINALIGN and ARCH_SLAB_MINALIGN are not always the same, as seen by building ARM collie_defconfig: mm/slob.c: In function 'kfree': mm/slob.c:482:153: warning: comparison of distinct pointer types lacks a cast mm/slob.c: In function 'ksize': mm/slob.c:501:153: warning: co