Re: [PATCH] mm/shmem: make find_get_pages_range() work for huge page

2019-02-14 Thread William Kucharski
> On Feb 12, 2019, at 4:57 PM, Yu Zhao wrote: > > It seems to me it's pefectly fine to use fields of xas directly, > and it's being done this way throughout the file. Fair enough. Reviewed-by: William Kucharski

Re: [PATCH] mm/shmem: make find_get_pages_range() work for huge page

2019-02-12 Thread Yu Zhao
On Thu, Jan 10, 2019 at 04:43:57AM -0700, William Kucharski wrote: > > > > On Jan 9, 2019, at 8:08 PM, Yu Zhao wrote: > > > > find_get_pages_range() and find_get_pages_range_tag() already > > correctly increment reference count on head when seeing compound > > page, but they may still use page

Re: [PATCH] mm/shmem: make find_get_pages_range() work for huge page

2019-01-10 Thread William Kucharski
> On Jan 9, 2019, at 8:08 PM, Yu Zhao wrote: > > find_get_pages_range() and find_get_pages_range_tag() already > correctly increment reference count on head when seeing compound > page, but they may still use page index from tail. Page index > from tail is always zero, so these functions don't

[PATCH] mm/shmem: make find_get_pages_range() work for huge page

2019-01-09 Thread Yu Zhao
find_get_pages_range() and find_get_pages_range_tag() already correctly increment reference count on head when seeing compound page, but they may still use page index from tail. Page index from tail is always zero, so these functions don't work on huge shmem. This hasn't been a problem because, AFA