Re: [PATCH] mm/page_owner: fix a crash after memory offline

2019-10-11 Thread Qian Cai
> On Oct 11, 2019, at 5:57 AM, David Hildenbrand wrote: > > You mean, I found the key to an unlimited amount of undetected BUGs, so I > should fix them? ;) No, it is more of for the sake of consistency, and the fact that all those bugs are only starting to show up only recently after applie

Re: [PATCH] mm/page_owner: fix a crash after memory offline

2019-10-11 Thread David Hildenbrand
On 10.10.19 21:12, Qian Cai wrote: On Thu, 2019-10-10 at 20:55 +0200, David Hildenbrand wrote: On 10.10.19 20:32, Qian Cai wrote: The linux-next series "mm/memory_hotplug: Shrink zones before removing memory" [1] seems make a crash easier to reproduce while reading /proc/pagetypeinfo after offl

Re: [PATCH] mm/page_owner: fix a crash after memory offline

2019-10-10 Thread Qian Cai
On Thu, 2019-10-10 at 20:55 +0200, David Hildenbrand wrote: > On 10.10.19 20:32, Qian Cai wrote: > > The linux-next series "mm/memory_hotplug: Shrink zones before removing > > memory" [1] seems make a crash easier to reproduce while reading > > /proc/pagetypeinfo after offlining a memory section. F

Re: [PATCH] mm/page_owner: fix a crash after memory offline

2019-10-10 Thread David Hildenbrand
On 10.10.19 20:32, Qian Cai wrote: The linux-next series "mm/memory_hotplug: Shrink zones before removing memory" [1] seems make a crash easier to reproduce while reading /proc/pagetypeinfo after offlining a memory section. Fix it by using pfn_to_online_page() in the PFN walker. Can you please

[PATCH] mm/page_owner: fix a crash after memory offline

2019-10-10 Thread Qian Cai
The linux-next series "mm/memory_hotplug: Shrink zones before removing memory" [1] seems make a crash easier to reproduce while reading /proc/pagetypeinfo after offlining a memory section. Fix it by using pfn_to_online_page() in the PFN walker. [1] https://lore.kernel.org/linux-mm/20191006085646.5