Re: [PATCH] mm/page_alloc: don't re-init pageset in zone_pcp_update()

2013-06-12 Thread Cody P Schafer
Anyhow, a reorganized (and clearer) changelog with the same content follows: --- I made a few wording tweaks: --- mm/page_alloc: don't re-init pageset in zone_pcp_update() When memory hotplug is triggered, we call pageset_init() on per-cpu-pagesets which both contain pages and are in use, causi

Re: [PATCH] mm/page_alloc: don't re-init pageset in zone_pcp_update()

2013-06-12 Thread Cody P Schafer
On 06/12/2013 02:20 PM, Andrew Morton wrote: On Tue, 11 Jun 2013 15:12:59 -0700 Cody P Schafer wrote: Factor pageset_set_high_and_batch() (which contains all needed logic too set a pageset's ->high and ->batch inrespective of system state) out of zone_pageset_init(), which avoids us calling p

Re: [PATCH] mm/page_alloc: don't re-init pageset in zone_pcp_update()

2013-06-12 Thread Andrew Morton
On Tue, 11 Jun 2013 15:12:59 -0700 Cody P Schafer wrote: > Factor pageset_set_high_and_batch() (which contains all needed logic too > set a pageset's ->high and ->batch inrespective of system state) out of > zone_pageset_init(), which avoids us calling pageset_init(), and > unsafely blowing away

[PATCH] mm/page_alloc: don't re-init pageset in zone_pcp_update()

2013-06-11 Thread Cody P Schafer
Factor pageset_set_high_and_batch() (which contains all needed logic too set a pageset's ->high and ->batch inrespective of system state) out of zone_pageset_init(), which avoids us calling pageset_init(), and unsafely blowing away a pageset at runtime (leaked pages and potentially some funky alloc