Re: [PATCH] mm/migrate: initialize pud_entry in migrate_vma()

2019-08-26 Thread Ralph Campbell
On 8/26/19 8:11 AM, Vlastimil Babka wrote: On 7/20/19 1:32 AM, Ralph Campbell wrote: When CONFIG_MIGRATE_VMA_HELPER is enabled, migrate_vma() calls migrate_vma_collect() which initializes a struct mm_walk but didn't initialize mm_walk.pud_entry. (Found by code inspection) Use a C structure ini

Re: [PATCH] mm/migrate: initialize pud_entry in migrate_vma()

2019-08-26 Thread Vlastimil Babka
On 7/20/19 1:32 AM, Ralph Campbell wrote: > When CONFIG_MIGRATE_VMA_HELPER is enabled, migrate_vma() calls > migrate_vma_collect() which initializes a struct mm_walk but > didn't initialize mm_walk.pud_entry. (Found by code inspection) > Use a C structure initialization to make sure it is set to NU

Re: [PATCH] mm/migrate: initialize pud_entry in migrate_vma()

2019-07-19 Thread John Hubbard
On 7/19/19 4:32 PM, Ralph Campbell wrote: > When CONFIG_MIGRATE_VMA_HELPER is enabled, migrate_vma() calls > migrate_vma_collect() which initializes a struct mm_walk but > didn't initialize mm_walk.pud_entry. (Found by code inspection) > Use a C structure initialization to make sure it is set to NU

[PATCH] mm/migrate: initialize pud_entry in migrate_vma()

2019-07-19 Thread Ralph Campbell
When CONFIG_MIGRATE_VMA_HELPER is enabled, migrate_vma() calls migrate_vma_collect() which initializes a struct mm_walk but didn't initialize mm_walk.pud_entry. (Found by code inspection) Use a C structure initialization to make sure it is set to NULL. Fixes: 8763cb45ab967 ("mm/migrate: new memory