Re: [PATCH] mm/memory-failure: Fix return wrong value when isolate page fail

2020-08-31 Thread Pankaj Gupta
> When we isolate page fail, we should not return 0, because we do not > set page HWPoison on any page. > > Signed-off-by: Muchun Song > --- > mm/memory-failure.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 696505f56910..4eb3c42ffe35

Re: [PATCH] mm/memory-failure: Fix return wrong value when isolate page fail

2020-08-31 Thread Oscar Salvador
On Sun, Aug 30, 2020 at 04:10:53PM +0800, Muchun Song wrote: > When we isolate page fail, we should not return 0, because we do not > set page HWPoison on any page. > > Signed-off-by: Muchun Song Thanks for spotting this Reviewed-by: Oscar Salvador > --- > mm/memory-failure.c | 1 + > 1 file

Re: [PATCH] mm/memory-failure: Fix return wrong value when isolate page fail

2020-08-30 Thread 堀口　直也
On Sun, Aug 30, 2020 at 03:44:18PM -0400, Qian Cai wrote: > On Sun, Aug 30, 2020 at 04:10:53PM +0800, Muchun Song wrote: > > When we isolate page fail, we should not return 0, because we do not > > set page HWPoison on any page. > > > > Signed-off-by: Muchun Song > > This seems solve the problem

Re: [PATCH] mm/memory-failure: Fix return wrong value when isolate page fail

2020-08-30 Thread Qian Cai
On Sun, Aug 30, 2020 at 04:10:53PM +0800, Muchun Song wrote: > When we isolate page fail, we should not return 0, because we do not > set page HWPoison on any page. > > Signed-off-by: Muchun Song This seems solve the problem for me that madvise(MADV_SOFT_OFFLINE) will run into ENOMEM eventually:

[PATCH] mm/memory-failure: Fix return wrong value when isolate page fail

2020-08-30 Thread Muchun Song
When we isolate page fail, we should not return 0, because we do not set page HWPoison on any page. Signed-off-by: Muchun Song --- mm/memory-failure.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 696505f56910..4eb3c42ffe35 100644 --- a/mm/me