Re: [PATCH] mm/memcg: bail out early when !memcg in mem_cgroup_lruvec

2020-11-30 Thread Andrew Morton
On Mon, 30 Nov 2020 22:44:11 +0300 Dmitry Osipenko wrote: > > From: Alex Shi > > Date: Wed, 25 Nov 2020 14:06:33 +0800 > > Subject: [PATCH v2] mm/memcg: bail out early when !memcg in > > mem_cgroup_lruvec > > > > Sometime, we use NULL memcg in mem_cgroup_lruvec(memcg, pgdat) > > so we could ge

Re: [PATCH] mm/memcg: bail out early when !memcg in mem_cgroup_lruvec

2020-11-30 Thread Dmitry Osipenko
29.11.2020 07:43, Alex Shi пишет: > > > 在 2020/11/28 下午12:02, Andrew Morton 写道: >> On Fri, 27 Nov 2020 11:08:35 +0800 Alex Shi >> wrote: >> >>> Sometime, we use NULL memcg in mem_cgroup_lruvec(memcg, pgdat) >>> so we could get out early in the situation to avoid useless checking. >>> >>> Also w

Re: [PATCH] mm/memcg: bail out early when !memcg in mem_cgroup_lruvec

2020-11-28 Thread Alex Shi
在 2020/11/28 下午12:02, Andrew Morton 写道: > On Fri, 27 Nov 2020 11:08:35 +0800 Alex Shi > wrote: > >> Sometime, we use NULL memcg in mem_cgroup_lruvec(memcg, pgdat) >> so we could get out early in the situation to avoid useless checking. >> >> Also warning if both parameter are NULL. > > Why d

Re: [PATCH] mm/memcg: bail out early when !memcg in mem_cgroup_lruvec

2020-11-28 Thread Andrew Morton
On Fri, 27 Nov 2020 11:08:35 +0800 Alex Shi wrote: > Sometime, we use NULL memcg in mem_cgroup_lruvec(memcg, pgdat) > so we could get out early in the situation to avoid useless checking. > > Also warning if both parameter are NULL. Why do you think a warning is needed here? > --- a/include/li

[PATCH] mm/memcg: bail out early when !memcg in mem_cgroup_lruvec

2020-11-26 Thread Alex Shi
Sometime, we use NULL memcg in mem_cgroup_lruvec(memcg, pgdat) so we could get out early in the situation to avoid useless checking. Also warning if both parameter are NULL. Signed-off-by: Alex Shi Cc: Andrew Morton Cc: Johannes Weiner Cc: Shakeel Butt Cc: Roman Gushchin Cc: Lorenzo Stoakes