Re: [PATCH] mm/kasan: make quarantine_lock a raw_spinlock_t

2018-10-19 Thread Peter Zijlstra
On Mon, Oct 15, 2018 at 04:35:29PM -0700, Andrew Morton wrote: > On Sat, 13 Oct 2018 15:50:58 +0200 Peter Zijlstra > wrote: > > > The whole raw_spinlock_t is for RT, no other reason. > > Oh. I never realised that. > > Is this documented anywhere? Do there exist guidelines which tell > non-rt

Re: [PATCH] mm/kasan: make quarantine_lock a raw_spinlock_t

2018-10-15 Thread Andrew Morton
On Sat, 13 Oct 2018 15:50:58 +0200 Peter Zijlstra wrote: > The whole raw_spinlock_t is for RT, no other reason. Oh. I never realised that. Is this documented anywhere? Do there exist guidelines which tell non-rt developers and reviewers when it should be used?

Re: [PATCH] mm/kasan: make quarantine_lock a raw_spinlock_t

2018-10-13 Thread Peter Zijlstra
On Fri, Oct 12, 2018 at 04:56:55PM -0700, Andrew Morton wrote: > There are several reasons for using raw_*, so an explanatory comment at > each site is called for. > > However it would be smarter to stop "using raw_* for several reasons". > Instead, create a differently named variant for each suc

Re: [PATCH] mm/kasan: make quarantine_lock a raw_spinlock_t

2018-10-12 Thread Andrew Morton
On Wed, 10 Oct 2018 23:49:45 +0200 Sebastian Andrzej Siewior wrote: > On 2018-10-10 11:57:41 [+0200], Dmitry Vyukov wrote: > > Yes. Clark's patch looks good to me. Probably would be useful to add a > > comment as to why raw spinlock is used (otherwise somebody may > > refactor it back later). >

Re: [PATCH] mm/kasan: make quarantine_lock a raw_spinlock_t

2018-10-11 Thread Dmitry Vyukov
On Wed, Oct 10, 2018 at 11:49 PM, Sebastian Andrzej Siewior wrote: > From: Clark Williams > Date: Tue, 18 Sep 2018 10:29:31 -0500 > > The static lock quarantine_lock is used in quarantine.c to protect the > quarantine queue datastructures. It is taken inside quarantine queue > manipulation routin

[PATCH] mm/kasan: make quarantine_lock a raw_spinlock_t

2018-10-10 Thread Sebastian Andrzej Siewior
From: Clark Williams Date: Tue, 18 Sep 2018 10:29:31 -0500 The static lock quarantine_lock is used in quarantine.c to protect the quarantine queue datastructures. It is taken inside quarantine queue manipulation routines (quarantine_put(), quarantine_reduce() and quarantine_remove_cache()), with