Re: [PATCH] mm/isolation: Remove redundant pfn_valid_within() in __first_valid_page()

2019-03-22 Thread Michal Hocko
On Thu 21-03-19 09:43:15, Anshuman Khandual wrote: > pfn_valid_within() calls pfn_valid() when CONFIG_HOLES_IN_ZONE making it > redundant for both definitions (w/wo CONFIG_MEMORY_HOTPLUG) of the helper > pfn_to_online_page() which either calls pfn_valid() or pfn_valid_within(). > pfn_valid_within()

Re: [PATCH] mm/isolation: Remove redundant pfn_valid_within() in __first_valid_page()

2019-03-21 Thread Michal Hocko
On Thu 21-03-19 10:42:40, Oscar Salvador wrote: > On Thu, Mar 21, 2019 at 09:43:15AM +0530, Anshuman Khandual wrote: > > pfn_valid_within() calls pfn_valid() when CONFIG_HOLES_IN_ZONE making it > > redundant for both definitions (w/wo CONFIG_MEMORY_HOTPLUG) of the helper > > pfn_to_online_page() wh

Re: [PATCH] mm/isolation: Remove redundant pfn_valid_within() in __first_valid_page()

2019-03-21 Thread Oscar Salvador
On Thu, Mar 21, 2019 at 09:43:15AM +0530, Anshuman Khandual wrote: > pfn_valid_within() calls pfn_valid() when CONFIG_HOLES_IN_ZONE making it > redundant for both definitions (w/wo CONFIG_MEMORY_HOTPLUG) of the helper > pfn_to_online_page() which either calls pfn_valid() or pfn_valid_within(). > pf

Re: [PATCH] mm/isolation: Remove redundant pfn_valid_within() in __first_valid_page()

2019-03-21 Thread Anshuman Khandual
On 03/21/2019 01:37 PM, Michal Hocko wrote: > On Thu 21-03-19 11:03:18, Anshuman Khandual wrote: >> >> >> On 03/21/2019 10:31 AM, Zi Yan wrote: >>> On 20 Mar 2019, at 21:13, Anshuman Khandual wrote: >>> pfn_valid_within() calls pfn_valid() when CONFIG_HOLES_IN_ZONE making it redundant

Re: [PATCH] mm/isolation: Remove redundant pfn_valid_within() in __first_valid_page()

2019-03-21 Thread Michal Hocko
On Thu 21-03-19 11:03:18, Anshuman Khandual wrote: > > > On 03/21/2019 10:31 AM, Zi Yan wrote: > > On 20 Mar 2019, at 21:13, Anshuman Khandual wrote: > > > >> pfn_valid_within() calls pfn_valid() when CONFIG_HOLES_IN_ZONE making it > >> redundant for both definitions (w/wo CONFIG_MEMORY_HOTPLUG)

Re: [PATCH] mm/isolation: Remove redundant pfn_valid_within() in __first_valid_page()

2019-03-20 Thread Anshuman Khandual
On 03/21/2019 10:31 AM, Zi Yan wrote: > On 20 Mar 2019, at 21:13, Anshuman Khandual wrote: > >> pfn_valid_within() calls pfn_valid() when CONFIG_HOLES_IN_ZONE making it >> redundant for both definitions (w/wo CONFIG_MEMORY_HOTPLUG) of the helper >> pfn_to_online_page() which either calls pfn_va

Re: [PATCH] mm/isolation: Remove redundant pfn_valid_within() in __first_valid_page()

2019-03-20 Thread Zi Yan
On 20 Mar 2019, at 21:13, Anshuman Khandual wrote: pfn_valid_within() calls pfn_valid() when CONFIG_HOLES_IN_ZONE making it redundant for both definitions (w/wo CONFIG_MEMORY_HOTPLUG) of the helper pfn_to_online_page() which either calls pfn_valid() or pfn_valid_within(). pfn_valid_within() be

[PATCH] mm/isolation: Remove redundant pfn_valid_within() in __first_valid_page()

2019-03-20 Thread Anshuman Khandual
pfn_valid_within() calls pfn_valid() when CONFIG_HOLES_IN_ZONE making it redundant for both definitions (w/wo CONFIG_MEMORY_HOTPLUG) of the helper pfn_to_online_page() which either calls pfn_valid() or pfn_valid_within(). pfn_valid_within() being 1 when !CONFIG_HOLES_IN_ZONE is irrelevant either wa