Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-

2017-02-09 Thread Vlastimil Babka
gt; +extern const kmalloc_info_t kmalloc_info[]; > > Why is the typedef needed? Can't we use something like Duh, right, I can't C. Thanks. 8<---- >From 15fc08501ddaaf1a6cf2c2d37755c61e1e5c1341 Mon Sep 17 00:00:00 2001 From: Vlastimil Babka Date: Wed, 8 Feb 2017 11

Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-

2017-02-08 Thread Andrew Morton
On Wed, 8 Feb 2017 10:12:13 +0100 Vlastimil Babka wrote: > On 02/07/2017 10:38 PM, Andrew Morton wrote: > > On Wed, 8 Feb 2017 01:15:17 +0800 kbuild test robot wrote: > > > >> Hi Vlastimil, > >> > >> [auto build test WARNING on mmotm/master] > >> [also build test WARNING on v4.10-rc7 next-2017

Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-

2017-02-08 Thread Christoph Lameter
On Wed, 8 Feb 2017, Vlastimil Babka wrote: > I was going to implement Christoph's suggestion and export the whole structure > in mm/slab.h, but gcc was complaining that I'm redefining it, until I created > a > typedef first. Is it worth the trouble? Below is how it would look like. Looks good to

Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-

2017-02-08 Thread Vlastimil Babka
Sorry, used old Willy's address. On 02/08/2017 10:12 AM, Vlastimil Babka wrote: On 02/07/2017 10:38 PM, Andrew Morton wrote: On Wed, 8 Feb 2017 01:15:17 +0800 kbuild test robot wrote: Hi Vlastimil, [auto build test WARNING on mmotm/master] [also build test WARNING on v4.10-rc7 next-20170207

Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-

2017-02-08 Thread Vlastimil Babka
On 02/07/2017 10:38 PM, Andrew Morton wrote: > On Wed, 8 Feb 2017 01:15:17 +0800 kbuild test robot wrote: > >> Hi Vlastimil, >> >> [auto build test WARNING on mmotm/master] >> [also build test WARNING on v4.10-rc7 next-20170207] >> [if your patch is applied to the wrong git tree, please drop us

Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-

2017-02-07 Thread Andrew Morton
On Wed, 8 Feb 2017 01:15:17 +0800 kbuild test robot wrote: > Hi Vlastimil, > > [auto build test WARNING on mmotm/master] > [also build test WARNING on v4.10-rc7 next-20170207] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: >

Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-

2017-02-07 Thread kbuild test robot
Hi Vlastimil, [auto build test WARNING on mmotm/master] [also build test WARNING on v4.10-rc7 next-20170207] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Vlastimil-Babka/mm-slab-rename-kmalloc

Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-

2017-02-06 Thread Christoph Lameter
On Mon, 6 Feb 2017, Matthew Wilcox wrote: > Could we lose the 'get_' from the front? I think 'kmalloc_cache_name()' is > just as informative. Hmmm.. Expose the static array in mm/slab.h instead? There may be other cases in which the allocator specific code may need that information.

Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-

2017-02-06 Thread Matthew Wilcox
On Fri, Feb 03, 2017 at 07:10:08PM +0100, Vlastimil Babka wrote: > diff --git a/mm/slab.c b/mm/slab.c > index a95fd4fed0a8..ede31b59bb9f 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -1293,7 +1293,8 @@ void __init kmem_cache_init(void) >* Initialize the caches that provide memory for the

Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-

2017-02-06 Thread Christoph Lameter
Acked-by: Christoph Lameter

Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-

2017-02-04 Thread Vlastimil Babka
On 4.2.2017 3:26, kbuild test robot wrote: > Hi Vlastimil, > > [auto build test WARNING on mmotm/master] > [also build test WARNING on v4.10-rc6] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] Hi, there are no warnings below? Vlastimil >

Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-

2017-02-03 Thread kbuild test robot
Hi Vlastimil, [auto build test WARNING on mmotm/master] [also build test WARNING on v4.10-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Vlastimil-Babka/mm-slab-rename-kmalloc-node-cache-to

[PATCH] mm, slab: rename kmalloc-node cache to kmalloc-

2017-02-03 Thread Vlastimil Babka
SLAB as part of its bootstrap pre-creates one kmalloc cache that can fit the kmem_cache_node management structure, and puts it into the generic kmalloc cache array (e.g. for 128b objects). The name of this cache is "kmalloc-node", which is confusing for readers of /proc/slabinfo as the cache is use