Re: [PATCH] mm, hugetlb: move the error handle logic out of normal code path

2014-05-18 Thread Aneesh Kumar K.V
Jianyu Zhan writes: > alloc_huge_page() now mixes normal code path with error handle logic. > This patches move out the error handle logic, to make normal code > path more clean and redue code duplicate. > > Signed-off-by: Jianyu Zhan Reviewed-by: Aneesh Kumar K.V > --- > mm/hugetlb.c | 26 +

Re: [PATCH] mm, hugetlb: move the error handle logic out of normal code path

2014-05-16 Thread Michal Hocko
On Thu 15-05-14 15:36:20, Andrew Morton wrote: > On Thu, 15 May 2014 11:01:42 +0200 Michal Hocko wrote: > > > On Wed 14-05-14 15:10:59, Jianyu Zhan wrote: > > > alloc_huge_page() now mixes normal code path with error handle logic. > > > This patches move out the error handle logic, to make normal

Re: [PATCH] mm, hugetlb: move the error handle logic out of normal code path

2014-05-15 Thread Davidlohr Bueso
On Wed, 2014-05-14 at 15:10 +0800, Jianyu Zhan wrote: > alloc_huge_page() now mixes normal code path with error handle logic. > This patches move out the error handle logic, to make normal code > path more clean and redue code duplicate. > > Signed-off-by: Jianyu Zhan Acked-by: Davidlohr Bueso

Re: [PATCH] mm, hugetlb: move the error handle logic out of normal code path

2014-05-15 Thread Andrew Morton
On Thu, 15 May 2014 11:01:42 +0200 Michal Hocko wrote: > On Wed 14-05-14 15:10:59, Jianyu Zhan wrote: > > alloc_huge_page() now mixes normal code path with error handle logic. > > This patches move out the error handle logic, to make normal code > > path more clean and redue code duplicate. > >

Re: [PATCH] mm, hugetlb: move the error handle logic out of normal code path

2014-05-15 Thread Michal Hocko
On Wed 14-05-14 15:10:59, Jianyu Zhan wrote: > alloc_huge_page() now mixes normal code path with error handle logic. > This patches move out the error handle logic, to make normal code > path more clean and redue code duplicate. I don't know. Part of the function returns and cleans up on its own a

[PATCH] mm, hugetlb: move the error handle logic out of normal code path

2014-05-14 Thread Jianyu Zhan
alloc_huge_page() now mixes normal code path with error handle logic. This patches move out the error handle logic, to make normal code path more clean and redue code duplicate. Signed-off-by: Jianyu Zhan --- mm/hugetlb.c | 26 +- 1 file changed, 13 insertions(+), 13 dele