Re: [PATCH] misc: fastrpc: fix memory leak

2020-04-29 Thread Bjorn Andersson
On Wed 29 Apr 08:29 PDT 2020, Srinivas Kandagatla wrote: > if misc_register() fails, previously allocated data is left without freeing, > this could result in memory leak. s/could/will/ > > So fix it! > As Markus pointed out, a Fixes: tag would be in order to make sure this is backported prop

Re: [PATCH] misc: fastrpc: fix memory leak

2020-04-29 Thread Markus Elfring
> if misc_register() fails, previously allocated data is left without freeing, > this could result in memory leak. How do you think about a wording variant like the following? Subject: [PATCH v2] misc: fastrpc: Fix an incomplete memory release in fastrpc_rpmsg_probe() Change descriptio

[PATCH] misc: fastrpc: fix memory leak

2020-04-29 Thread Srinivas Kandagatla
if misc_register() fails, previously allocated data is left without freeing, this could result in memory leak. So fix it! Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fa

[PATCH] misc: fastrpc: fix memory leak

2019-07-04 Thread Jorge Ramirez-Ortiz
Deallocate the buffer when no longer required. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/misc/fastrpc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 98603e235cf0..af8fd2101a1d 100644 --- a/drivers/misc/fastrpc.c