Re: [PATCH] misc: bcm-vk: Fix a couple error codes in probe()

2021-02-03 Thread Dan Carpenter
On Wed, Feb 03, 2021 at 11:15:35AM -0800, Scott Branden wrote: > Thanks Dan, > > On 2021-02-03 6:42 a.m., Dan Carpenter wrote: > > These errors should return negative error codes instead of returning > > success. > Do you have a script running to report such issues or just manually reviewing > to

Re: [PATCH] misc: bcm-vk: Fix a couple error codes in probe()

2021-02-03 Thread Scott Branden
Thanks Dan, On 2021-02-03 6:42 a.m., Dan Carpenter wrote: > These errors should return negative error codes instead of returning > success. Do you have a script running to report such issues or just manually reviewing to find such paths? > > Fixes: 064ffc7c3939 ("misc: bcm-vk: add autoload support

[PATCH] misc: bcm-vk: Fix a couple error codes in probe()

2021-02-03 Thread Dan Carpenter
These errors should return negative error codes instead of returning success. Fixes: 064ffc7c3939 ("misc: bcm-vk: add autoload support") Fixes: 522f692686a7 ("misc: bcm-vk: add Broadcom VK driver") Signed-off-by: Dan Carpenter --- drivers/misc/bcm-vk/bcm_vk_dev.c | 4 +++- 1 file changed, 3 inse