Re: [PATCH] mips: Remove q-accessors from non-64bit platforms

2019-06-24 Thread Paul Burton
Hello, Serge Semin wrote: > There are some generic drivers in the kernel, which make use of the > q-accessors or their derivatives. While at current asm/io.h the accessors > are defined, their implementation is only applicable either for 64bit > systems, or for systems with cpu_has_64bits flag set

Re: [PATCH] mips: Remove q-accessors from non-64bit platforms

2019-06-24 Thread Maciej W. Rozycki
Arnd, We're getting into MMIO and barriers again, sigh. Cc-ing people recently involved then. On Fri, 21 Jun 2019, Arnd Bergmann wrote: > > > > > The other property of packet memory and similar things is that you > > > > > basically want memcpy()-behavior with no byteswaps. This is one > > >

Re: [PATCH] mips: Remove q-accessors from non-64bit platforms

2019-06-21 Thread Arnd Bergmann
On Fri, Jun 21, 2019 at 2:24 PM Maciej W. Rozycki wrote: > On Fri, 21 Jun 2019, Arnd Bergmann wrote: > > > > The other property of packet memory and similar things is that you > > > > basically want memcpy()-behavior with no byteswaps. This is one > > > > of the few cases in which __raw_readq() is

Re: [PATCH] mips: Remove q-accessors from non-64bit platforms

2019-06-21 Thread Maciej W. Rozycki
On Fri, 21 Jun 2019, Arnd Bergmann wrote: > > > The other property of packet memory and similar things is that you > > > basically want memcpy()-behavior with no byteswaps. This is one > > > of the few cases in which __raw_readq() is actually the right accessor > > > in (mostly) portable code. > >

Re: [PATCH] mips: Remove q-accessors from non-64bit platforms

2019-06-21 Thread Arnd Bergmann
On Fri, Jun 21, 2019 at 12:09 PM Maciej W. Rozycki wrote: > > On Fri, 21 Jun 2019, Arnd Bergmann wrote: > > > > The use of 64-bit operations to access option's packet memory, which is > > > true SRAM, i.e. no side effects, is to improve throughput only and there's > > > no need for atomicity here

Re: [PATCH] mips: Remove q-accessors from non-64bit platforms

2019-06-21 Thread Maciej W. Rozycki
On Fri, 21 Jun 2019, Arnd Bergmann wrote: > > The use of 64-bit operations to access option's packet memory, which is > > true SRAM, i.e. no side effects, is to improve throughput only and there's > > no need for atomicity here nor also any kind of barriers, except at the > > conclusion. Splitti

Re: [PATCH] mips: Remove q-accessors from non-64bit platforms

2019-06-21 Thread Arnd Bergmann
On Thu, Jun 20, 2019 at 8:19 PM Maciej W. Rozycki wrote: > > On Thu, 20 Jun 2019, Paul Burton wrote: > > > So this seems pretty reasonable. Build testing all our defconfigs only > > showed up one issue for decstation_defconfig & decstation_r4k_defconfig: > > > > drivers/net/fddi/defza.c: In func

Re: [PATCH] mips: Remove q-accessors from non-64bit platforms

2019-06-20 Thread Serge Semin
Hello Paul, On Thu, Jun 20, 2019 at 05:40:04PM +, Paul Burton wrote: > Hi Serge, > > On Fri, Jun 14, 2019 at 09:33:42AM +0300, Serge Semin wrote: > > There are some generic drivers in the kernel, which make use of the > > q-accessors or their derivatives. While at current asm/io.h the accesso

Re: [PATCH] mips: Remove q-accessors from non-64bit platforms

2019-06-20 Thread Maciej W. Rozycki
On Thu, 20 Jun 2019, Paul Burton wrote: > So this seems pretty reasonable. Build testing all our defconfigs only > showed up one issue for decstation_defconfig & decstation_r4k_defconfig: > > drivers/net/fddi/defza.c: In function 'fza_reads': > drivers/net/fddi/defza.c:88:17: error: implicit

Re: [PATCH] mips: Remove q-accessors from non-64bit platforms

2019-06-20 Thread Paul Burton
Hi Serge, On Fri, Jun 14, 2019 at 09:33:42AM +0300, Serge Semin wrote: > There are some generic drivers in the kernel, which make use of the > q-accessors or their derivatives. While at current asm/io.h the accessors > are defined, their implementation is only applicable either for 64bit > systems

[PATCH] mips: Remove q-accessors from non-64bit platforms

2019-06-13 Thread Serge Semin
There are some generic drivers in the kernel, which make use of the q-accessors or their derivatives. While at current asm/io.h the accessors are defined, their implementation is only applicable either for 64bit systems, or for systems with cpu_has_64bits flag set. Obviously there are MIPS systems