Re: [PATCH] mips: Remove compiler check in unroll macro

2020-07-10 Thread Nathan Chancellor
On Fri, Jul 10, 2020 at 03:43:43PM -0700, Linus Torvalds wrote: > On Fri, Jul 10, 2020 at 3:34 PM Nathan Chancellor > wrote: > > > > Clang 8 was chosen as a minimum version for this check because there > > were some improvements around __builtin_constant_p in that release. In > > reality, MIPS was

Re: [PATCH] mips: Remove compiler check in unroll macro

2020-07-10 Thread Linus Torvalds
On Fri, Jul 10, 2020 at 3:34 PM Nathan Chancellor wrote: > > Clang 8 was chosen as a minimum version for this check because there > were some improvements around __builtin_constant_p in that release. In > reality, MIPS was not even buildable until clang 9 so that check was not > technically necess

[PATCH] mips: Remove compiler check in unroll macro

2020-07-10 Thread Nathan Chancellor
CONFIG_CC_IS_GCC is undefined when Clang is used, which breaks the build (see our Travis link below). Clang 8 was chosen as a minimum version for this check because there were some improvements around __builtin_constant_p in that release. In reality, MIPS was not even buildable until clang 9 so th