Re: [PATCH] mips/oprofile: Fix fallthrough placement

2020-08-21 Thread Thomas Bogendoerfer
On Fri, Aug 21, 2020 at 04:23:28AM -0500, Gustavo A. R. Silva wrote: > > > On 8/21/20 03:46, He Zhe wrote: > > > > > > On 8/21/20 3:48 PM, Thomas Bogendoerfer wrote: > >> On Thu, Aug 20, 2020 at 08:54:40PM +0800, zhe...@windriver.com wrote: > >>> From: He Zhe > >>> > >>> We want neither > >>>

Re: [PATCH] mips/oprofile: Fix fallthrough placement

2020-08-21 Thread Gustavo A. R. Silva
On 8/21/20 03:46, He Zhe wrote: > > > On 8/21/20 3:48 PM, Thomas Bogendoerfer wrote: >> On Thu, Aug 20, 2020 at 08:54:40PM +0800, zhe...@windriver.com wrote: >>> From: He Zhe >>> >>> We want neither >>> " >>> include/linux/compiler_attributes.h:201:41: warning: statement will never >>> be exe

Re: [PATCH] mips/oprofile: Fix fallthrough placement

2020-08-21 Thread He Zhe
On 8/21/20 3:48 PM, Thomas Bogendoerfer wrote: > On Thu, Aug 20, 2020 at 08:54:40PM +0800, zhe...@windriver.com wrote: >> From: He Zhe >> >> We want neither >> " >> include/linux/compiler_attributes.h:201:41: warning: statement will never >> be executed [-Wswitch-unreachable] >> 201 | # defin

Re: [PATCH] mips/oprofile: Fix fallthrough placement

2020-08-21 Thread Thomas Bogendoerfer
On Thu, Aug 20, 2020 at 08:54:40PM +0800, zhe...@windriver.com wrote: > From: He Zhe > > We want neither > " > include/linux/compiler_attributes.h:201:41: warning: statement will never > be executed [-Wswitch-unreachable] > 201 | # define fallthrough __attribute__((__fallthrough__)) > |

[PATCH] mips/oprofile: Fix fallthrough placement

2020-08-20 Thread zhe.he
From: He Zhe We want neither " include/linux/compiler_attributes.h:201:41: warning: statement will never be executed [-Wswitch-unreachable] 201 | # define fallthrough __attribute__((__fallthrough__)) | ^ " nor " include/linux/compiler_attributes.h:201:41: