Re: [PATCH] mfd: cros_ec: Use proper protocol transfer function

2016-11-28 Thread Brian Norris
Hi Lee, On Wed, Nov 23, 2016 at 08:37:49AM +, Lee Jones wrote: > On Tue, 22 Nov 2016, Brian Norris wrote: > > On Wed, Aug 10, 2016 at 01:45:12PM -0700, Brian Norris wrote: > > > From: Shawn Nematbakhsh > > > > > > pkt_xfer should be used for protocol v3, and cmd_xfer otherwise. We had > > >

Re: [PATCH] mfd: cros_ec: Use proper protocol transfer function

2016-11-23 Thread Lee Jones
On Tue, 22 Nov 2016, Brian Norris wrote: > + Benson > > On Wed, Aug 10, 2016 at 01:45:12PM -0700, Brian Norris wrote: > > From: Shawn Nematbakhsh > > > > pkt_xfer should be used for protocol v3, and cmd_xfer otherwise. We had > > one instance of these functions correct, but not the second, fall

Re: [PATCH] mfd: cros_ec: Use proper protocol transfer function

2016-11-22 Thread Benson Leung
Hey Brian, On Tue, Nov 22, 2016 at 2:19 PM, Brian Norris wrote: > I believe this was supposed to go through Olof. Olof, are you out there? > > Or Benson? I see this: > > http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1273587.html > [PATCH] platform/chrome : Add myself as Maintainer >

Re: [PATCH] mfd: cros_ec: Use proper protocol transfer function

2016-11-22 Thread Brian Norris
+ Benson On Wed, Aug 10, 2016 at 01:45:12PM -0700, Brian Norris wrote: > From: Shawn Nematbakhsh > > pkt_xfer should be used for protocol v3, and cmd_xfer otherwise. We had > one instance of these functions correct, but not the second, fall-back > case. We use the fall-back only when the first c

Re: [PATCH] mfd: cros_ec: Use proper protocol transfer function

2016-08-30 Thread Lee Jones
On Wed, 10 Aug 2016, Brian Norris wrote: > From: Shawn Nematbakhsh > > pkt_xfer should be used for protocol v3, and cmd_xfer otherwise. We had > one instance of these functions correct, but not the second, fall-back > case. We use the fall-back only when the first command returns an > IN_PROGRES

[PATCH] mfd: cros_ec: Use proper protocol transfer function

2016-08-10 Thread Brian Norris
From: Shawn Nematbakhsh pkt_xfer should be used for protocol v3, and cmd_xfer otherwise. We had one instance of these functions correct, but not the second, fall-back case. We use the fall-back only when the first command returns an IN_PROGRESS status, which is only used on some EC firmwares wher