Re: [PATCH] mfd: cros_ec: Avoid unneeded internal declaration warning

2018-10-09 Thread Stephen Boyd
Quoting Nathan Chancellor (2018-09-27 18:16:14) > On Wed, Sep 26, 2018 at 08:33:17PM -0700, Nathan Chancellor wrote: > > diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c > > index 999dac752bcc..8f9d6964173e 100644 > > --- a/drivers/mfd/cros_ec_dev.c > > +++ b/drivers/mfd/cros_ec_d

Re: [PATCH] mfd: cros_ec: Avoid unneeded internal declaration warning

2018-10-09 Thread Lee Jones
On Thu, 27 Sep 2018, Nathan Chancellor wrote: > On Wed, Sep 26, 2018 at 08:33:17PM -0700, Nathan Chancellor wrote: > > Clang warns: > > > > drivers/mfd/cros_ec_dev.c:509:40: warning: variable 'cros_ec_id' is not > > needed and will not be emitted [-Wunneeded-internal-declaration] > > static const

Re: [PATCH] mfd: cros_ec: Avoid unneeded internal declaration warning

2018-09-27 Thread Nathan Chancellor
On Wed, Sep 26, 2018 at 08:33:17PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/mfd/cros_ec_dev.c:509:40: warning: variable 'cros_ec_id' is not > needed and will not be emitted [-Wunneeded-internal-declaration] > static const struct platform_device_id cros_ec_id[] = { >

[PATCH] mfd: cros_ec: Avoid unneeded internal declaration warning

2018-09-26 Thread Nathan Chancellor
Clang warns: drivers/mfd/cros_ec_dev.c:509:40: warning: variable 'cros_ec_id' is not needed and will not be emitted [-Wunneeded-internal-declaration] static const struct platform_device_id cros_ec_id[] = { ^ 1 warning generated. Avoid this warning by adding