Re: [PATCH] mfd: cros-ec: copy the whole event when msg->version is 0

2018-10-09 Thread Lee Jones
On Thu, 27 Sep 2018, Emil Karlson wrote: > Commit 57e94c8b974db2d83c60e1139c89a70806abbea0 caused cros-ec keyboard events > be truncated on many chromebooks so that Left and Right keys on Column 12 were > always 0. This commit fixes the issue by restoring the old semantics when the > protocol vers

Re: [PATCH] mfd: cros-ec: copy the whole event when msg->version is 0

2018-09-28 Thread Emil Renner Berthing
On Fri, 28 Sep 2018 at 14:15, Neil Armstrong wrote: > On 27/09/2018 11:24, Emil Karlson wrote: > > Commit 57e94c8b974db2d83c60e1139c89a70806abbea0 caused cros-ec keyboard > > events > > be truncated on many chromebooks so that Left and Right keys on Column 12 > > were > > always 0. This commit f

Re: [PATCH] mfd: cros-ec: copy the whole event when msg->version is 0

2018-09-28 Thread Neil Armstrong
Hi All, On 27/09/2018 11:24, Emil Karlson wrote: > Commit 57e94c8b974db2d83c60e1139c89a70806abbea0 caused cros-ec keyboard events > be truncated on many chromebooks so that Left and Right keys on Column 12 were > always 0. This commit fixes the issue by restoring the old semantics when the > proto

Re: [PATCH] mfd: cros-ec: copy the whole event when msg->version is 0

2018-09-27 Thread Emil Karlson
To note I have almost no idea what I am doing and ended up wondering, whether the messages are always truncated and it only shows on version 0, because the messages are not padded to longer lenght. Alternatively the ret could possibly be used as copy length without the -1, right now I am unable to

[PATCH] mfd: cros-ec: copy the whole event when msg->version is 0

2018-09-27 Thread Emil Karlson
Commit 57e94c8b974db2d83c60e1139c89a70806abbea0 caused cros-ec keyboard events be truncated on many chromebooks so that Left and Right keys on Column 12 were always 0. This commit fixes the issue by restoring the old semantics when the protocol version is 0. --- drivers/platform/chrome/cros_ec_pro