Re: [PATCH] memcg: remove mem_cgroup_reclaimable check from soft reclaim

2014-10-22 Thread Michal Hocko
On Wed 22-10-14 08:40:25, Johannes Weiner wrote: > On Wed, Oct 22, 2014 at 01:21:16PM +0200, Michal Hocko wrote: > > On Tue 21-10-14 14:22:39, Johannes Weiner wrote: > > [...] > > > From 27bd24b00433d9f6c8d60ba2b13dbff158b06c13 Mon Sep 17 00:00:00 2001 > > > From: Johannes Weiner > > > Date: Tue,

Re: [PATCH] memcg: remove mem_cgroup_reclaimable check from soft reclaim

2014-10-22 Thread Johannes Weiner
On Wed, Oct 22, 2014 at 01:21:16PM +0200, Michal Hocko wrote: > On Tue 21-10-14 14:22:39, Johannes Weiner wrote: > [...] > > From 27bd24b00433d9f6c8d60ba2b13dbff158b06c13 Mon Sep 17 00:00:00 2001 > > From: Johannes Weiner > > Date: Tue, 21 Oct 2014 09:53:54 -0400 > > Subject: [patch] mm: memcontro

Re: [PATCH] memcg: remove mem_cgroup_reclaimable check from soft reclaim

2014-10-22 Thread Michal Hocko
On Tue 21-10-14 14:22:39, Johannes Weiner wrote: [...] > From 27bd24b00433d9f6c8d60ba2b13dbff158b06c13 Mon Sep 17 00:00:00 2001 > From: Johannes Weiner > Date: Tue, 21 Oct 2014 09:53:54 -0400 > Subject: [patch] mm: memcontrol: do not filter reclaimable nodes in NUMA > round-robin > > The round-r

Re: [PATCH] memcg: remove mem_cgroup_reclaimable check from soft reclaim

2014-10-21 Thread Vladimir Davydov
On Tue, Oct 21, 2014 at 02:22:39PM -0400, Johannes Weiner wrote: > On Tue, Oct 21, 2014 at 05:15:50PM +0400, Vladimir Davydov wrote: > > mem_cgroup_reclaimable() checks whether a cgroup has reclaimable pages > > on *any* NUMA node. However, the only place where it's called is > > mem_cgroup_soft_re

Re: [PATCH] memcg: remove mem_cgroup_reclaimable check from soft reclaim

2014-10-21 Thread Johannes Weiner
On Tue, Oct 21, 2014 at 05:15:50PM +0400, Vladimir Davydov wrote: > mem_cgroup_reclaimable() checks whether a cgroup has reclaimable pages > on *any* NUMA node. However, the only place where it's called is > mem_cgroup_soft_reclaim(), which tries to reclaim memory from a > *specific* zone. So the w

Re: [PATCH] memcg: remove mem_cgroup_reclaimable check from soft reclaim

2014-10-21 Thread Michal Hocko
On Tue 21-10-14 17:15:50, Vladimir Davydov wrote: > mem_cgroup_reclaimable() checks whether a cgroup has reclaimable pages > on *any* NUMA node. However, the only place where it's called is > mem_cgroup_soft_reclaim(), which tries to reclaim memory from a > *specific* zone. So the way how it's used

[PATCH] memcg: remove mem_cgroup_reclaimable check from soft reclaim

2014-10-21 Thread Vladimir Davydov
mem_cgroup_reclaimable() checks whether a cgroup has reclaimable pages on *any* NUMA node. However, the only place where it's called is mem_cgroup_soft_reclaim(), which tries to reclaim memory from a *specific* zone. So the way how it's used is incorrect - it will return true even if the cgroup doe