Re: [PATCH] memcg: mem_cgroup_migrate() may be called with irq disabled

2016-06-21 Thread Vladimir Davydov
On Mon, Jun 20, 2016 at 02:41:58PM -0400, Tejun Heo wrote: > mem_cgroup_migrate() uses local_irq_disable/enable() but can be called > with irq disabled from migrate_page_copy(). This ends up enabling irq > while holding a irq context lock triggering the following lockdep > warning. Fix it by usin

Re: [PATCH] memcg: mem_cgroup_migrate() may be called with irq disabled

2016-06-21 Thread Michal Hocko
On Mon 20-06-16 14:41:58, Tejun Heo wrote: > Hello, > > Christian, I *think* this should fix it. Can you please verify? > > Thanks! > -- 8< -- > mem_cgroup_migrate() uses local_irq_disable/enable() but can be called > with irq disabled from migrate_page_copy(). This ends up enabling irq

Re: [PATCH] memcg: mem_cgroup_migrate() may be called with irq disabled

2016-06-20 Thread Christian Borntraeger
On 06/20/2016 08:41 PM, Tejun Heo wrote: > Hello, > > Christian, I *think* this should fix it. Can you please verify? I cannot reliably reproduce the bug :-/,but at least I have not seen it with this patch and the patch makes sense and matches the traces. > > Thanks! > -- 8< -- > mem_c

Re: [PATCH] memcg: mem_cgroup_migrate() may be called with irq disabled

2016-06-20 Thread Johannes Weiner
On Mon, Jun 20, 2016 at 02:41:58PM -0400, Tejun Heo wrote: > mem_cgroup_migrate() uses local_irq_disable/enable() but can be called > with irq disabled from migrate_page_copy(). This ends up enabling irq > while holding a irq context lock triggering the following lockdep > warning. Fix it by usin

[PATCH] memcg: mem_cgroup_migrate() may be called with irq disabled

2016-06-20 Thread Tejun Heo
Hello, Christian, I *think* this should fix it. Can you please verify? Thanks! -- 8< -- mem_cgroup_migrate() uses local_irq_disable/enable() but can be called with irq disabled from migrate_page_copy(). This ends up enabling irq while holding a irq context lock triggering the following