Re: [PATCH] memcg: expose root cgroup's memory.stat

2020-05-15 Thread Chris Down
Hey Shakeel, Shakeel Butt writes: One way to measure the efficiency of memory reclaim is to look at the ratio (pgscan+pfrefill)/pgsteal. However at the moment these stats are not updated consistently at the system level and the ratio of these are not very meaningful. The pgsteal and pgscan are u

Re: [PATCH] memcg: expose root cgroup's memory.stat

2020-05-15 Thread Shakeel Butt
On Fri, May 15, 2020 at 11:09 AM Johannes Weiner wrote: > > On Fri, May 15, 2020 at 10:49:22AM -0700, Shakeel Butt wrote: > > On Fri, May 15, 2020 at 8:00 AM Roman Gushchin wrote: > > > On Fri, May 15, 2020 at 06:44:44AM -0700, Shakeel Butt wrote: > > > > On Fri, May 15, 2020 at 6:24 AM Johannes

Re: [PATCH] memcg: expose root cgroup's memory.stat

2020-05-15 Thread Shakeel Butt
On Fri, May 15, 2020 at 11:09 AM Roman Gushchin wrote: > > On Fri, May 15, 2020 at 10:49:22AM -0700, Shakeel Butt wrote: > > On Fri, May 15, 2020 at 8:00 AM Roman Gushchin wrote: > > > > > > On Fri, May 15, 2020 at 06:44:44AM -0700, Shakeel Butt wrote: > > > > On Fri, May 15, 2020 at 6:24 AM Joha

Re: [PATCH] memcg: expose root cgroup's memory.stat

2020-05-15 Thread Johannes Weiner
On Fri, May 15, 2020 at 10:49:22AM -0700, Shakeel Butt wrote: > On Fri, May 15, 2020 at 8:00 AM Roman Gushchin wrote: > > On Fri, May 15, 2020 at 06:44:44AM -0700, Shakeel Butt wrote: > > > On Fri, May 15, 2020 at 6:24 AM Johannes Weiner > > > wrote: > > > > You're right. It should only bypass t

Re: [PATCH] memcg: expose root cgroup's memory.stat

2020-05-15 Thread Roman Gushchin
On Fri, May 15, 2020 at 10:49:22AM -0700, Shakeel Butt wrote: > On Fri, May 15, 2020 at 8:00 AM Roman Gushchin wrote: > > > > On Fri, May 15, 2020 at 06:44:44AM -0700, Shakeel Butt wrote: > > > On Fri, May 15, 2020 at 6:24 AM Johannes Weiner > > > wrote: > > > > > > > > On Fri, May 15, 2020 at 1

Re: [PATCH] memcg: expose root cgroup's memory.stat

2020-05-15 Thread Shakeel Butt
On Fri, May 15, 2020 at 8:00 AM Roman Gushchin wrote: > > On Fri, May 15, 2020 at 06:44:44AM -0700, Shakeel Butt wrote: > > On Fri, May 15, 2020 at 6:24 AM Johannes Weiner wrote: > > > > > > On Fri, May 15, 2020 at 10:29:55AM +0200, Michal Hocko wrote: > > > > On Sat 09-05-20 07:06:38, Shakeel Bu

Re: [PATCH] memcg: expose root cgroup's memory.stat

2020-05-15 Thread Roman Gushchin
On Fri, May 15, 2020 at 06:44:44AM -0700, Shakeel Butt wrote: > On Fri, May 15, 2020 at 6:24 AM Johannes Weiner wrote: > > > > On Fri, May 15, 2020 at 10:29:55AM +0200, Michal Hocko wrote: > > > On Sat 09-05-20 07:06:38, Shakeel Butt wrote: > > > > On Fri, May 8, 2020 at 2:44 PM Johannes Weiner

Re: [PATCH] memcg: expose root cgroup's memory.stat

2020-05-15 Thread Shakeel Butt
On Fri, May 15, 2020 at 6:24 AM Johannes Weiner wrote: > > On Fri, May 15, 2020 at 10:29:55AM +0200, Michal Hocko wrote: > > On Sat 09-05-20 07:06:38, Shakeel Butt wrote: > > > On Fri, May 8, 2020 at 2:44 PM Johannes Weiner wrote: > > > > > > > > On Fri, May 08, 2020 at 10:06:30AM -0700, Shakeel

Re: [PATCH] memcg: expose root cgroup's memory.stat

2020-05-15 Thread Johannes Weiner
On Fri, May 15, 2020 at 10:29:55AM +0200, Michal Hocko wrote: > On Sat 09-05-20 07:06:38, Shakeel Butt wrote: > > On Fri, May 8, 2020 at 2:44 PM Johannes Weiner wrote: > > > > > > On Fri, May 08, 2020 at 10:06:30AM -0700, Shakeel Butt wrote: > > > > One way to measure the efficiency of memory recl

Re: [PATCH] memcg: expose root cgroup's memory.stat

2020-05-15 Thread Michal Hocko
On Sat 09-05-20 07:06:38, Shakeel Butt wrote: > On Fri, May 8, 2020 at 2:44 PM Johannes Weiner wrote: > > > > On Fri, May 08, 2020 at 10:06:30AM -0700, Shakeel Butt wrote: > > > One way to measure the efficiency of memory reclaim is to look at the > > > ratio (pgscan+pfrefill)/pgsteal. However at

Re: [PATCH] memcg: expose root cgroup's memory.stat

2020-05-09 Thread Yafang Shao
On Sat, May 9, 2020 at 10:06 PM Shakeel Butt wrote: > > On Fri, May 8, 2020 at 2:44 PM Johannes Weiner wrote: > > > > On Fri, May 08, 2020 at 10:06:30AM -0700, Shakeel Butt wrote: > > > One way to measure the efficiency of memory reclaim is to look at the > > > ratio (pgscan+pfrefill)/pgsteal. Ho

Re: [PATCH] memcg: expose root cgroup's memory.stat

2020-05-09 Thread Shakeel Butt
On Fri, May 8, 2020 at 2:44 PM Johannes Weiner wrote: > > On Fri, May 08, 2020 at 10:06:30AM -0700, Shakeel Butt wrote: > > One way to measure the efficiency of memory reclaim is to look at the > > ratio (pgscan+pfrefill)/pgsteal. However at the moment these stats are > > not updated consistently

Re: [PATCH] memcg: expose root cgroup's memory.stat

2020-05-08 Thread Johannes Weiner
On Fri, May 08, 2020 at 10:06:30AM -0700, Shakeel Butt wrote: > One way to measure the efficiency of memory reclaim is to look at the > ratio (pgscan+pfrefill)/pgsteal. However at the moment these stats are > not updated consistently at the system level and the ratio of these are > not very meaning

[PATCH] memcg: expose root cgroup's memory.stat

2020-05-08 Thread Shakeel Butt
One way to measure the efficiency of memory reclaim is to look at the ratio (pgscan+pfrefill)/pgsteal. However at the moment these stats are not updated consistently at the system level and the ratio of these are not very meaningful. The pgsteal and pgscan are updated for only global reclaim while