Re: [PATCH] media: vsp1: Fix a reference count leak.

On 16/06/2020 04:09, Laurent Pinchart wrote: > On Tue, Jun 16, 2020 at 05:07:34AM +0300, Laurent Pinchart wrote: >> Hi Qiushi, >> >> (CC'ing Rafael and Geert) >> >> Thank you for the patch. >> >> On Sat, Jun 13, 2020 at 06:23:57PM -0500, wu000...@umn.edu wrote: >>> From: Qiushi Wu >>> >>> pm_runti

Re: [PATCH] media: vsp1: Fix a reference count leak.

On Tue, Jun 16, 2020 at 05:07:34AM +0300, Laurent Pinchart wrote: > Hi Qiushi, > > (CC'ing Rafael and Geert) > > Thank you for the patch. > > On Sat, Jun 13, 2020 at 06:23:57PM -0500, wu000...@umn.edu wrote: > > From: Qiushi Wu > > > > pm_runtime_get_sync() increments the runtime PM usage coun

Re: [PATCH] media: vsp1: Fix a reference count leak.

Hi Qiushi, (CC'ing Rafael and Geert) Thank you for the patch. On Sat, Jun 13, 2020 at 06:23:57PM -0500, wu000...@umn.edu wrote: > From: Qiushi Wu > > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code, causing incorrect ref count if > pm_runtime_

[PATCH] media: vsp1: Fix a reference count leak.

From: Qiushi Wu pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, causing incorrect ref count if pm_runtime_put_noidle() is not called in error handling paths. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Fixes: 1e6af546ee66 ("