Re: [PATCH] media: v4l: cadence: Fix how unsued lanes are handled in 'csi2rx_start()'

2019-09-17 Thread Dan Carpenter
On Mon, Sep 16, 2019 at 09:24:26PM +0200, Christophe JAILLET wrote: > Le 16/09/2019 à 08:28, Dan Carpenter a écrit : > > On Fri, Sep 13, 2019 at 09:57:09AM +0200, Maxime Ripard wrote: > > > Hi Christophe, > > > > > > On Thu, Sep 12, 2019 at 10:44:50PM +0200, Christophe JAILLET wrote: > > > > The 2

Re: [PATCH] media: v4l: cadence: Fix how unsued lanes are handled in 'csi2rx_start()'

2019-09-16 Thread Christophe JAILLET
Le 16/09/2019 à 08:28, Dan Carpenter a écrit : On Fri, Sep 13, 2019 at 09:57:09AM +0200, Maxime Ripard wrote: Hi Christophe, On Thu, Sep 12, 2019 at 10:44:50PM +0200, Christophe JAILLET wrote: The 2nd parameter of 'find_first_zero_bit()' is a number of bits, not of bytes. So use 'BITS_PER_LONG

Re: [PATCH] media: v4l: cadence: Fix how unsued lanes are handled in 'csi2rx_start()'

2019-09-15 Thread Dan Carpenter
On Fri, Sep 13, 2019 at 09:57:09AM +0200, Maxime Ripard wrote: > Hi Christophe, > > On Thu, Sep 12, 2019 at 10:44:50PM +0200, Christophe JAILLET wrote: > > The 2nd parameter of 'find_first_zero_bit()' is a number of bits, not of > > bytes. So use 'BITS_PER_LONG' instead of 'sizeof(lanes_used)'. >

Re: [PATCH] media: v4l: cadence: Fix how unsued lanes are handled in 'csi2rx_start()'

2019-09-13 Thread Maxime Ripard
Hi Christophe, On Thu, Sep 12, 2019 at 10:44:50PM +0200, Christophe JAILLET wrote: > The 2nd parameter of 'find_first_zero_bit()' is a number of bits, not of > bytes. So use 'BITS_PER_LONG' instead of 'sizeof(lanes_used)'. > > Fixes: 1fc3b37f34f6 ("media: v4l: cadence: Add Cadence MIPI-CSI2 RX dr

Re: [PATCH] media: v4l: cadence: Fix how unsued lanes are handled in 'csi2rx_start()'

2019-09-13 Thread walter harms
Am 12.09.2019 22:44, schrieb Christophe JAILLET: > The 2nd parameter of 'find_first_zero_bit()' is a number of bits, not of > bytes. So use 'BITS_PER_LONG' instead of 'sizeof(lanes_used)'. > > Fixes: 1fc3b37f34f6 ("media: v4l: cadence: Add Cadence MIPI-CSI2 RX driver") > Signed-off-by: Christop

[PATCH] media: v4l: cadence: Fix how unsued lanes are handled in 'csi2rx_start()'

2019-09-12 Thread Christophe JAILLET
The 2nd parameter of 'find_first_zero_bit()' is a number of bits, not of bytes. So use 'BITS_PER_LONG' instead of 'sizeof(lanes_used)'. Fixes: 1fc3b37f34f6 ("media: v4l: cadence: Add Cadence MIPI-CSI2 RX driver") Signed-off-by: Christophe JAILLET --- This patch is purely speculative. Using BITS_P