Hi Dhiraj,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on staging/staging-testing soc/for-next v5.8-rc7
next-20200728]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch,
Alright sorry, I will ignore this patch and will commit the new patch
in another file.
On Tue, Jul 28, 2020 at 10:28 PM Greg KH wrote:
>
> On Tue, Jul 28, 2020 at 10:13:22PM +0530, Dhiraj Sharma wrote:
> > > As the bot said, only do one type of thing per patch, and "fix all
> > > checkpatch erro
On Tue, Jul 28, 2020 at 10:13:22PM +0530, Dhiraj Sharma wrote:
> > As the bot said, only do one type of thing per patch, and "fix all
> > checkpatch errors/warnings" is not one type of thing.
>
> So should I send a fresh patch with minimal fixes? instead of replying
> to this mail with [PATCH 01]
> As the bot said, only do one type of thing per patch, and "fix all
> checkpatch errors/warnings" is not one type of thing.
So should I send a fresh patch with minimal fixes? instead of replying
to this mail with [PATCH 01]
On Tue, Jul 28, 2020 at 09:14:24PM +0530, Dhiraj Sharma wrote:
> Sorry, I didn't realize that I committed a mistake by not replying to
> all. It was an accidental mistake which will not be committed in
> future now.
>
> >
> > That is not needed in a changelog text.
> >
>
> Alright Sir.
>
> > Nei
Sorry I had committed a mistake by not replying to all.
> Hi Dhiraj,
>
> On 28/07/2020 16:30, Dhiraj Sharma wrote:
> > As per eudyptula challenge task 10 I had to fix coding styles. Thus I
> > used checkpatch.pl script and fixed a chunk of warnings and few errors.
>
> As both drivers/staging/media
Sorry, I didn't realize that I committed a mistake by not replying to
all. It was an accidental mistake which will not be committed in
future now.
>
> That is not needed in a changelog text.
>
Alright Sir.
> Neither is this, please be specific about what you have fixed. My bot
> should kick in
Hi Dhiraj,
On 28/07/2020 16:30, Dhiraj Sharma wrote:
> As per eudyptula challenge task 10 I had to fix coding styles. Thus I
> used checkpatch.pl script and fixed a chunk of warnings and few errors.
As both drivers/staging/media/usbvision/Kconfig and .../TODO say, this
driver is deprecated and wi
On Tue, Jul 28, 2020 at 08:00:04PM +0530, Dhiraj Sharma wrote:
> As per eudyptula challenge task 10 I had to fix coding styles.
That is not needed in a changelog text.
> Thus I
> used checkpatch.pl script and fixed a chunk of warnings and few errors.
Neither is this, please be specific about wha
On Tue, Jul 28, 2020 at 08:00:04PM +0530, Dhiraj Sharma wrote:
> As per eudyptula challenge task 10 I had to fix coding styles. Thus I
> used checkpatch.pl script and fixed a chunk of warnings and few errors.
>
> Signed-off-by: Dhiraj Sharma
> ---
> .../staging/media/usbvision/usbvision-video.c
As per eudyptula challenge task 10 I had to fix coding styles. Thus I
used checkpatch.pl script and fixed a chunk of warnings and few errors.
Signed-off-by: Dhiraj Sharma
---
.../staging/media/usbvision/usbvision-video.c | 91 +++
1 file changed, 52 insertions(+), 39 deletions(-)
11 matches
Mail list logo
