Re: [PATCH] media: pvrusb2: fix parsing error

Hi Hans, I just made another patch as suggested, I think I need some more work on the commit log. Please take a look and let me know - Thanks, - Tong On Wed, Aug 19, 2020 at 10:38 AM Hans Verkuil wrote: > > Hi Tong, > > On 16/08/2020 08:49, Tong Zhang wrote: > > pvr2_std_str_to_id() returns 0 on

Re: [PATCH] media: pvrusb2: fix parsing error

Hi Hans, Thank you very much for your comments. The change looks good to me. -- However, I'm not quite familiar with the patch submission process in this situation. Would you like to go ahead and create an improved version? Thanks, - Tong On Wed, Aug 19, 2020 at 10:38 AM Hans Verkuil wrote: > >

Re: [PATCH] media: pvrusb2: fix parsing error

Hi Tong, On 16/08/2020 08:49, Tong Zhang wrote: > pvr2_std_str_to_id() returns 0 on failure and 1 on success, > however the caller is checking failure case using <0 > > Signed-off-by: Tong Zhang > --- > drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deleti

[PATCH] media: pvrusb2: fix parsing error

pvr2_std_str_to_id() returns 0 on failure and 1 on success, however the caller is checking failure case using <0 Signed-off-by: Tong Zhang --- drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/