Re: [PATCH] media: leds: as3645a: add V4L2_FLASH_LED_CLASS depdendency

2017-09-08 Thread Pavel Machek
On Tue 2017-09-05 09:13:20, Arnd Bergmann wrote: > We get a link error when V4L2_FLASH_LED_CLASS=m and AS3645A is built-in: > > drivers/leds/leds-as3645a.o: In function `as3645a_v4l2_setup': > leds-as3645a.c:(.text+0x258): undefined reference to `v4l2_flash_init' > leds-as3645a.c:(.text+0x284): un

Re: [PATCH] media: leds: as3645a: add V4L2_FLASH_LED_CLASS depdendency

2017-09-05 Thread Sakari Ailus
Hi Jacek and Arnd, Thanks for fixing this plus the ack! I chatted with Mauro, and as the patches are still only in mediatree, we'll apply this there, possibly with a minor spelling fix to the subject (depdendency -> dependency). https://git.linuxtv.org/sailus/media_tree.git/commit/?h=as3645a-

Re: [PATCH] media: leds: as3645a: add V4L2_FLASH_LED_CLASS depdendency

2017-09-05 Thread Jacek Anaszewski
Hi Arnd, Thanks for the patch. On 09/05/2017 09:13 AM, Arnd Bergmann wrote: > We get a link error when V4L2_FLASH_LED_CLASS=m and AS3645A is built-in: > > drivers/leds/leds-as3645a.o: In function `as3645a_v4l2_setup': > leds-as3645a.c:(.text+0x258): undefined reference to `v4l2_flash_init' > led

[PATCH] media: leds: as3645a: add V4L2_FLASH_LED_CLASS depdendency

2017-09-05 Thread Arnd Bergmann
We get a link error when V4L2_FLASH_LED_CLASS=m and AS3645A is built-in: drivers/leds/leds-as3645a.o: In function `as3645a_v4l2_setup': leds-as3645a.c:(.text+0x258): undefined reference to `v4l2_flash_init' leds-as3645a.c:(.text+0x284): undefined reference to `v4l2_flash_indicator_init' leds-as364