On 03/22/2014 11:40 AM, Frank Schäfer wrote:
I'm more concerned about the fact that readers of the code could think
that this is a write with a variable length, while the length is
actually always the same.
Fair enough.
em28xx_reg_len() is a somewhat dirty hack for vidioc_[g,s]_register
deb
Am 22.03.2014 16:22, schrieb Shuah Khan:
> On 03/22/2014 06:32 AM, Frank Schäfer wrote:
>>
>> Am 21.03.2014 22:04, schrieb Shuah Khan:
>>> Change em28xx_scaler_set() to use em28xx_reg_len() to get register
>>> lengths for EM28XX_R30_HSCALELOW and EM28XX_R32_VSCALELOW registers,
>>> instead of hard
On 03/22/2014 06:32 AM, Frank Schäfer wrote:
Am 21.03.2014 22:04, schrieb Shuah Khan:
Change em28xx_scaler_set() to use em28xx_reg_len() to get register
lengths for EM28XX_R30_HSCALELOW and EM28XX_R32_VSCALELOW registers,
instead of hard-coding the length. Moved em28xx_reg_len() definition
for
Am 21.03.2014 22:04, schrieb Shuah Khan:
> Change em28xx_scaler_set() to use em28xx_reg_len() to get register
> lengths for EM28XX_R30_HSCALELOW and EM28XX_R32_VSCALELOW registers,
> instead of hard-coding the length. Moved em28xx_reg_len() definition
> for it to be visible to em28xx_scaler_set().
Change em28xx_scaler_set() to use em28xx_reg_len() to get register
lengths for EM28XX_R30_HSCALELOW and EM28XX_R32_VSCALELOW registers,
instead of hard-coding the length. Moved em28xx_reg_len() definition
for it to be visible to em28xx_scaler_set().
Signed-off-by: Shuah Khan
---
drivers/media/us
5 matches
Mail list logo