Re: [PATCH] media: drx: fix a missing check of return value

Em Thu, 20 Dec 2018 00:57:44 -0600 Kangjie Lu escreveu: > Function drxj_dap_write_reg16(), which writes data to buffer, may fail. > We need to check if it fails, and if so, we should goto error. Did you test this on a real hardware? This kind of patch has a potential of breaking things, as, on

[PATCH] media: drx: fix a missing check of return value

Function drxj_dap_write_reg16(), which writes data to buffer, may fail. We need to check if it fails, and if so, we should goto error. Otherwise, the buffer will have incorrect data. Signed-off-by: Kangjie Lu --- drivers/media/dvb-frontends/drx39xyj/drxj.c | 6 +- 1 file changed, 5 insertion