Re: [PATCH] mb_cache_shrink() frees unexpected caches

2005-07-15 Thread Akinobu Mita
2005-07-16 (Sat) 03:44 +0200 Andreas Gruenbacher wrote: > Removing the cache parameter from mb_cache_shrink would break when more than > one mb_cache is used per filesystem, correct. Leaving the parameter in and > adding your patch is more "future proof", so I'm fine with it. Are you > actually

Re: [PATCH] mb_cache_shrink() frees unexpected caches

2005-07-15 Thread Andreas Gruenbacher
On Friday 15 July 2005 17:07, Akinobu Mita wrote: > 2005-07-15 (Fri) 16:36 +0200 Andreas Gruenbacher wrote: > > The cache parameter could indeed be removed. Not that it would matter > > much... > > Currently, mbcache is used only for xattr on ext2/ext3 and reiserfs. > In other words, only one type

Re: [PATCH] mb_cache_shrink() frees unexpected caches

2005-07-15 Thread Akinobu Mita
2005-07-16 (Sat) 00:07 +0900 Akinobu Mita wrote: > Currently, mbcache is used only for xattr on ext2/ext3 and reiserfs. > In other words, only one type of mbcache is used per-filesystem. > So any problems don't happen without the patch I sent. > > But, for example when someone use mbcache as anoth

Re: [PATCH] mb_cache_shrink() frees unexpected caches

2005-07-15 Thread Akinobu Mita
2005-07-15 (Fri) 16:36 +0200 Andreas Gruenbacher wrote: > The cache parameter could indeed be removed. Not that it would matter much... > Currently, mbcache is used only for xattr on ext2/ext3 and reiserfs. In other words, only one type of mbcache is used per-filesystem. So any problems don't ha

Re: [PATCH] mb_cache_shrink() frees unexpected caches

2005-07-15 Thread Andreas Gruenbacher
On Friday 15 July 2005 15:41, Akinobu Mita wrote: > > > --- 2.6-rc/fs/mbcache.c.orig 2005-07-14 20:40:34.0 +0900 > > > +++ 2.6-rc/fs/mbcache.c 2005-07-14 20:43:42.0 +0900 > > > @@ -329,7 +329,7 @@ mb_cache_shrink(struct mb_cache *cache, > > > list_for_each_safe(l, ltmp, &mb

Re: [PATCH] mb_cache_shrink() frees unexpected caches

2005-07-15 Thread Akinobu Mita
> > --- 2.6-rc/fs/mbcache.c.orig2005-07-14 20:40:34.0 +0900 > > +++ 2.6-rc/fs/mbcache.c 2005-07-14 20:43:42.0 +0900 > > @@ -329,7 +329,7 @@ mb_cache_shrink(struct mb_cache *cache, > > list_for_each_safe(l, ltmp, &mb_cache_lru_list) { > > struct mb_cache_

Re: [PATCH] mb_cache_shrink() frees unexpected caches

2005-07-15 Thread Andreas Gruenbacher
Hello, On Thursday 14 July 2005 15:07, Akinobu Mita wrote: > mb_cache_shrink() tries to free all sort of mbcache in the lru list. > > All user of mb_cache_shrink() are ext2/ext3 xattr. > > Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> > > --- 2.6-rc/fs/mbcache.c.orig 2005-07-14 20:40:34.000

[PATCH] mb_cache_shrink() frees unexpected caches

2005-07-14 Thread Akinobu Mita
mb_cache_shrink() tries to free all sort of mbcache in the lru list. All user of mb_cache_shrink() are ext2/ext3 xattr. Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> --- 2.6-rc/fs/mbcache.c.orig2005-07-14 20:40:34.0 +0900 +++ 2.6-rc/fs/mbcache.c 2005-07-14 20:43:42.0 +0900