Re: [PATCH] macvtap: rcu_dereference outside read-lock section

2012-08-11 Thread David Miller
From: Denis Efremov Date: Sat, 11 Aug 2012 14:05:27 +0400 > - if (rcu_dereference(vlan->taps[i]) == q) > + if (rcu_dereference_protected(vlan->taps[i], > + lockdep_is_held(&macvtap_lock)) == q) You must use the proper combination of TAB charact

[PATCH] macvtap: rcu_dereference outside read-lock section

2012-08-11 Thread Denis Efremov
In this case it is not an error. rcu_dereference occurs in update section. Replacement by rcu_dereference_protected (with spinlock) in order to prevent lockdep complaint. Found by Linux Driver Verification project (linuxtesting.org) Signed-off-by: Denis Efremov --- drivers/net/macvtap.c |3