Re: [PATCH] macb: Fix speed setting

2008-02-23 Thread Jeff Garzik
Atsushi Nemoto wrote: Fix NCFGR.SPD setting on 10Mbps. This bug was introduced by conversion to generic PHY layer in kernel 2.6.23. Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> --- diff --git a/drivers/net/macb.c b/drivers/net/macb.c index 81bf005..1d210ed 100644 --- a/drivers/net/macb.c +

Re: [PATCH] macb: Fix speed setting

2008-02-23 Thread Haavard Skinnemoen
On Sat, 23 Feb 2008 00:03:23 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Thu, 21 Feb 2008 17:41:05 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> > wrote: > > > From: Atsushi Nemoto <[EMAIL PROTECTED]> > > > > Fix NCFGR.SPD setting on 10Mbps. This bug was introduced by > > conversion to

Re: [PATCH] macb: Fix speed setting

2008-02-23 Thread Andrew Morton
On Thu, 21 Feb 2008 17:41:05 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > From: Atsushi Nemoto <[EMAIL PROTECTED]> > > Fix NCFGR.SPD setting on 10Mbps. This bug was introduced by > conversion to generic PHY layer in kernel 2.6.23. So.. shouldn't we fix it in 2.6.23.x and 2.6.24.x? >

Re: [PATCH] macb: Fix speed setting

2008-02-22 Thread Haavard Skinnemoen
On Thu, 21 Feb 2008 17:41:05 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > From: Atsushi Nemoto <[EMAIL PROTECTED]> > > Fix NCFGR.SPD setting on 10Mbps. This bug was introduced by > conversion to generic PHY layer in kernel 2.6.23. > > Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> >

[PATCH] macb: Fix speed setting

2008-02-21 Thread Haavard Skinnemoen
From: Atsushi Nemoto <[EMAIL PROTECTED]> Fix NCFGR.SPD setting on 10Mbps. This bug was introduced by conversion to generic PHY layer in kernel 2.6.23. Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- drivers/net/macb.c |2 +- 1 file

Re: [PATCH] macb: Fix speed setting

2008-02-21 Thread Haavard Skinnemoen
On Fri, 22 Feb 2008 00:07:31 +0900 (JST) Atsushi Nemoto <[EMAIL PROTECTED]> wrote: > > I'm willing to take your word for it, but some documentation would be > > really nice... > > Well, simple grepping drivers/net/phy enlighten us ;) Yeah, the patch certainly looks correct as far as I can tell

Re: [PATCH] macb: Fix speed setting

2008-02-21 Thread Atsushi Nemoto
Excuse me for sending broken mail... On Thu, 21 Feb 2008 15:12:46 +0100, Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > I have to admit that even after looking through include/linux/phy.h and > include/linux/mii.h, I don't have the faintest idea what values we can > expect to find in the "speed"

Re: [PATCH] macb: Fix speed setting

2008-02-21 Thread Atsushi Nemoto
On Thu, 21 Feb 2008 15:12:46 +0100, Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > I have to admit that even after looking through include/linux/phy.h and > include/linux/mii.h, I don't have the faintest idea what values we can > expect to find in the "speed" field of phydev. The comment above st

Re: [PATCH] macb: Fix speed setting

2008-02-21 Thread Haavard Skinnemoen
On Thu, 21 Feb 2008 22:50:54 +0900 (JST) Atsushi Nemoto <[EMAIL PROTECTED]> wrote: > Fix NCFGR.SPD setting on 10Mbps. This bug was introduced by > conversion to generic PHY layer in kernel 2.6.23. > > Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> > --- > diff --git a/drivers/net/macb.c b/dri

[PATCH] macb: Fix speed setting

2008-02-21 Thread Atsushi Nemoto
Fix NCFGR.SPD setting on 10Mbps. This bug was introduced by conversion to generic PHY layer in kernel 2.6.23. Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> --- diff --git a/drivers/net/macb.c b/drivers/net/macb.c index 81bf005..1d210ed 100644 --- a/drivers/net/macb.c +++ b/drivers/net/macb.c