Re: [PATCH] mac80211_hwsim: release driver when ieee80211_register_hw fails

2014-10-29 Thread Johannes Berg
On Tue, 2014-10-28 at 09:31 +0800, Junjie Mao wrote: > The driver is not released when ieee80211_register_hw fails in > mac80211_hwsim_create_radio, leading to the access to the unregistered (and > possibly freed) device in platform_driver_unregister: Applied. johannes -- To unsubscribe from thi

Re: [PATCH] mac80211_hwsim: release driver when ieee80211_register_hw fails

2014-10-29 Thread Fengguang Wu
On Wed, Oct 29, 2014 at 06:23:02PM +0800, Junjie Mao wrote: > I was not familiar with the acquiring/releasing API either, until I met > with this bug... > > Perhaps we can use static checkers to avoid these issues as early as > possible. Any suggestions? CC Dan. His smatch checker might be able (

Re: [PATCH] mac80211_hwsim: release driver when ieee80211_register_hw fails

2014-10-29 Thread Junjie Mao
I was not familiar with the acquiring/releasing API either, until I met with this bug... Perhaps we can use static checkers to avoid these issues as early as possible. Any suggestions? Best Regards Junjie Mao Martin Pitt writes: > Acked-By: Martin Pitt > > Hello Junjie, > > Junjie Mao [2014-1

Re: [PATCH] mac80211_hwsim: release driver when ieee80211_register_hw fails

2014-10-28 Thread Martin Pitt
Acked-By: Martin Pitt Hello Junjie, Junjie Mao [2014-10-28 9:31 +0800]: > The driver is not released when ieee80211_register_hw fails in > mac80211_hwsim_create_radio, leading to the access to the unregistered (and > possibly freed) device in platform_driver_unregister: Many thanks for fixing

[PATCH] mac80211_hwsim: release driver when ieee80211_register_hw fails

2014-10-27 Thread Junjie Mao
The driver is not released when ieee80211_register_hw fails in mac80211_hwsim_create_radio, leading to the access to the unregistered (and possibly freed) device in platform_driver_unregister: [0.447547] mac80211_hwsim: ieee80211_register_hw failed (-2) [0.448292] [ cut here ]-