Re: [PATCH] mac80211: use oneshot blink API for LED triggers

2013-07-25 Thread Fabio Baltieri
On Thu, Jul 25, 2013 at 09:58:21AM +0200, Johannes Berg wrote: > > So, are you definitely rejecting this patch or should I fix indentation > > and send a v2? > > I think I'll take it, I kinda hope nobody will really care much about it > but the behaviour looks better and the code is simpler, so ..

Re: [PATCH] mac80211: use oneshot blink API for LED triggers

2013-07-25 Thread Johannes Berg
On Wed, 2013-07-24 at 10:53 +0200, Fabio Baltieri wrote: > On Wed, Jul 24, 2013 at 10:14:25AM +0200, Johannes Berg wrote: > > On Wed, 2013-07-24 at 02:09 +0200, Fabio Baltieri wrote: > > > Changes mac80211 LED trigger code to use the generic > > > led_trigger_blink_oneshot() API for transmit and re

Re: [PATCH] mac80211: use oneshot blink API for LED triggers

2013-07-24 Thread Fabio Baltieri
On Wed, Jul 24, 2013 at 10:14:25AM +0200, Johannes Berg wrote: > On Wed, 2013-07-24 at 02:09 +0200, Fabio Baltieri wrote: > > Changes mac80211 LED trigger code to use the generic > > led_trigger_blink_oneshot() API for transmit and receive activity > > indication. > > > > This gives a better feedb

Re: [PATCH] mac80211: use oneshot blink API for LED triggers

2013-07-24 Thread Johannes Berg
On Wed, 2013-07-24 at 02:09 +0200, Fabio Baltieri wrote: > Changes mac80211 LED trigger code to use the generic > led_trigger_blink_oneshot() API for transmit and receive activity > indication. > > This gives a better feedback to the user, as with the new API each > activity event results in a vis

[PATCH] mac80211: use oneshot blink API for LED triggers

2013-07-23 Thread Fabio Baltieri
Changes mac80211 LED trigger code to use the generic led_trigger_blink_oneshot() API for transmit and receive activity indication. This gives a better feedback to the user, as with the new API each activity event results in a visible blink, while a constant traffic results in a continuous blink at

[PATCH] mac80211: use oneshot blink API for LED triggers

2013-07-23 Thread Fabio Baltieri
Hi Johannes, John, This patch changes the mac80211 LED driver to use the generic oneshot LED API. The current mac80211 blink code seems to lead to very short tx blinks and toggles the LED on tx. The oneshot API ensure a complete LED on-off cycle for each blink event, thus getting a better result