Re: [PATCH] lpfc: nvmet_fc: fix format string

2017-05-31 Thread Martin K. Petersen
Arnd, > The lpfc_nvmeio_data() tracing helper always takes a format string and > three additional arguments. The latest caller has a format string with > only two integer arguments, causing this harmless warning: Applied to 4.12/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux En

Re: [PATCH] lpfc: nvmet_fc: fix format string

2017-05-29 Thread James Smart
Patch is fine. Signed-off-by: James Smart -- james On 5/19/2017 1:04 AM, Arnd Bergmann wrote: The lpfc_nvmeio_data() tracing helper always takes a format string and three additional arguments. The latest caller has a format string with only two integer arguments, causing this harmless warnin

Re: [PATCH] lpfc: nvmet_fc: fix format string

2017-05-23 Thread Martin K. Petersen
Arnd, > The lpfc_nvmeio_data() tracing helper always takes a format string and > three additional arguments. The latest caller has a format string with > only two integer arguments, causing this harmless warning: James? -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] lpfc: nvmet_fc: fix format string

2017-05-20 Thread Joe Perches
On Sat, 2017-05-20 at 21:10 +0200, Arnd Bergmann wrote: > On Sat, May 20, 2017 at 12:28 PM, Joe Perches wrote: > > On Fri, 2017-05-19 at 10:04 +0200, Arnd Bergmann wrote: > > > The lpfc_nvmeio_data() tracing helper always takes a format string and > > > three additional arguments. > > > > No it d

Re: [PATCH] lpfc: nvmet_fc: fix format string

2017-05-20 Thread Arnd Bergmann
On Sat, May 20, 2017 at 12:28 PM, Joe Perches wrote: > On Fri, 2017-05-19 at 10:04 +0200, Arnd Bergmann wrote: >> The lpfc_nvmeio_data() tracing helper always takes a format string and >> three additional arguments. > > No it doesn't. It takes a format and arguments. > > I don't disagree with the

Re: [PATCH] lpfc: nvmet_fc: fix format string

2017-05-20 Thread Joe Perches
On Fri, 2017-05-19 at 10:04 +0200, Arnd Bergmann wrote: > The lpfc_nvmeio_data() tracing helper always takes a format string and > three additional arguments. No it doesn't. It takes a format and arguments. I don't disagree with the patch, just the characterization of the lpfc_mvmeio_data call i

[PATCH] lpfc: nvmet_fc: fix format string

2017-05-19 Thread Arnd Bergmann
The lpfc_nvmeio_data() tracing helper always takes a format string and three additional arguments. The latest caller has a format string with only two integer arguments, causing this harmless warning: drivers/scsi/lpfc/lpfc_nvmet.c: In function 'lpfc_nvmet_xmt_fcp_release': drivers/scsi/lpfc/lpfc_