Re: [PATCH] lp: implement proper detach function for parport_driver lp

2013-06-20 Thread Hannes Weisbach
Am 19.06.2013 um 20:32 schrieb Greg Kroah-Hartman: > >> They are doing what I am doing: translating whatever the >> user does on a /dev/parportN-node and sending device-specific commands >> over USB. When they do parport_announce_port(), lp.c should also be >> initialized and they should have th

Re: [PATCH] lp: implement proper detach function for parport_driver lp

2013-06-19 Thread Greg Kroah-Hartman
On Wed, Jun 19, 2013 at 07:04:51PM +0200, Hannes Weisbach wrote: > >> Signed-off-by: Hannes Weisbach > >> --- > >> Granted, for normal parport drivers this is usually not an issue, > >> because the device does not go away. However, I am currently writing a > >> Linux device driver for a USB to par

Re: [PATCH] lp: implement proper detach function for parport_driver lp

2013-06-19 Thread Hannes Weisbach
>> Signed-off-by: Hannes Weisbach >> --- >> Granted, for normal parport drivers this is usually not an issue, >> because the device does not go away. However, I am currently writing a >> Linux device driver for a USB to parallel port converter [0] and >> therefore need proper detaching. Additional

Re: [PATCH] lp: implement proper detach function for parport_driver lp

2013-06-03 Thread Greg Kroah-Hartman
On Sat, Jun 01, 2013 at 10:02:21PM +0200, Hannes Weisbach wrote: > From: Hannes Weisbach > > The lp pardevice driver does not have a proper detach function. Consequently, > parport_unregister_device() is not called when the underlying parport driver > calls parport_remove_port(). As a result, t

[PATCH] lp: implement proper detach function for parport_driver lp

2013-06-01 Thread Hannes Weisbach
From: Hannes Weisbach The lp pardevice driver does not have a proper detach function. Consequently, parport_unregister_device() is not called when the underlying parport driver calls parport_remove_port(). As a result, the ref count of the parport driver's module does not go to zero and the dr