Re: [PATCH] locking/lockdep: Remove the cross-release locking checks

2017-12-15 Thread Byungchul Park
On Sat, Dec 16, 2017 at 6:15 AM, Theodore Ts'o wrote: > On Fri, Dec 15, 2017 at 05:39:25PM +0900, Byungchul Park wrote: >> >> All locks should belong to one class if each path of acquisition >> can be switchable each other within the class at any time. >> Otherwise, they should belong to a differe

Re: [PATCH] locking/lockdep: Remove the cross-release locking checks

2017-12-15 Thread Theodore Ts'o
On Fri, Dec 15, 2017 at 05:39:25PM +0900, Byungchul Park wrote: > > All locks should belong to one class if each path of acquisition > can be switchable each other within the class at any time. > Otherwise, they should belong to a different class. OK, so let's go back to my case of a Network Bloc

Re: [PATCH] locking/lockdep: Remove the cross-release locking checks

2017-12-15 Thread Byungchul Park
On Fri, Dec 15, 2017 at 3:24 PM, Theodore Ts'o wrote: > seems that lock classification as a solution to cross-release false > positives seems unlikely: For this, let me explain more. For example, either to use cross-release or to consider wait_for_completion() in submit_bio_wait() manually u

Re: [PATCH] locking/lockdep: Remove the cross-release locking checks

2017-12-14 Thread Byungchul Park
On Fri, Dec 15, 2017 at 3:24 PM, Theodore Ts'o wrote: > On Fri, Dec 15, 2017 at 01:05:43PM +0900, Byungchul Park wrote: >> For example, in the case of fs issues, for now we can >> invalidate wait_for_completion() in submit_bio_wait() > > And this will spawn a checkpatch.pl ERROR: > >

Re: [PATCH] locking/lockdep: Remove the cross-release locking checks

2017-12-14 Thread Theodore Ts'o
On Fri, Dec 15, 2017 at 01:05:43PM +0900, Byungchul Park wrote: > For example, in the case of fs issues, for now we can > invalidate wait_for_completion() in submit_bio_wait() And this will spawn a checkpatch.pl ERROR: ERROR("LOCKDEP", "lockdep_no_valid

Re: [PATCH] locking/lockdep: Remove the cross-release locking checks

2017-12-14 Thread Byungchul Park
On Thu, Dec 14, 2017 at 2:01 PM, Byungchul Park wrote: > On Wed, Dec 13, 2017 at 7:46 PM, Ingo Molnar wrote: >> >> * Byungchul Park wrote: >> >>> Lockdep works, based on the following: >>> >>>(1) Classifying locks properly >>>(2) Checking relationship between the classes >>> >>> If (1) i

Re: [PATCH] locking/lockdep: Remove the cross-release locking checks

2017-12-13 Thread Byungchul Park
On Wed, Dec 13, 2017 at 7:46 PM, Ingo Molnar wrote: > > * Byungchul Park wrote: > >> Lockdep works, based on the following: >> >>(1) Classifying locks properly >>(2) Checking relationship between the classes >> >> If (1) is not good or (2) is not good, then we >> might get false positives

[PATCH] locking/lockdep: Remove the cross-release locking checks

2017-12-13 Thread Ingo Molnar
>From e966eaeeb623f09975ef362c2866fae6f86844f9 Mon Sep 17 00:00:00 2001 From: Ingo Molnar Date: Tue, 12 Dec 2017 12:31:16 +0100 Subject: [PATCH] locking/lockdep: Remove the cross-release locking checks This code (CONFIG_LOCKDEP_CROSSRELEASE=y and CONFIG_LOCKDEP_COMPLETIONS=y), while it found a number