Re: [PATCH] locking/lockdep: Fix lock IRQ usage initialization bug

2019-07-08 Thread Qian Cai
> On Jul 8, 2019, at 9:21 PM, Yuyang Du wrote: > > The problem should have been fixed with this in that pull: > > locking/lockdep: Move mark_lock() inside CONFIG_TRACE_IRQFLAGS && > CONFIG_PROVE_LOCKING > > and this is a better fix than mine. I don’t think so. That commit was included in to

Re: [PATCH] locking/lockdep: Fix lock IRQ usage initialization bug

2019-07-08 Thread Yuyang Du
The problem should have been fixed with this in that pull: locking/lockdep: Move mark_lock() inside CONFIG_TRACE_IRQFLAGS && CONFIG_PROVE_LOCKING and this is a better fix than mine. Thanks, Yuyang On Tue, 9 Jul 2019 at 01:32, Qian Cai wrote: > > I saw Ingo send a pull request to Linus for 5.3

Re: [PATCH] locking/lockdep: Fix lock IRQ usage initialization bug

2019-07-08 Thread Qian Cai
I saw Ingo send a pull request to Linus for 5.3 [1] includes the offensive commit "locking/lockdep: Consolidate lock usage bit initialization" but did not include this patch. [1] https://lore.kernel.org/lkml/20190708093516.ga57...@gmail.com/ On Mon, 2019-06-10 at 13:52 +0800, Yuyang Du wrote: > T

Re: [PATCH] locking/lockdep: Fix lock IRQ usage initialization bug

2019-06-11 Thread Yuyang Du
Great, thanks. On Mon, 10 Jun 2019 at 23:35, Qian Cai wrote: > > On Mon, 2019-06-10 at 13:52 +0800, Yuyang Du wrote: > > The commit: > > > > 091806515124b20 ("locking/lockdep: Consolidate lock usage bit > > initialization") > > > > misses marking LOCK_USED flag at IRQ usage initialization when

Re: [PATCH] locking/lockdep: Fix lock IRQ usage initialization bug

2019-06-10 Thread Qian Cai
On Mon, 2019-06-10 at 13:52 +0800, Yuyang Du wrote: > The commit: > >   091806515124b20 ("locking/lockdep: Consolidate lock usage bit > initialization") > > misses marking LOCK_USED flag at IRQ usage initialization when > CONFIG_TRACE_IRQFLAGS > or CONFIG_PROVE_LOCKING is not defined. Fix it. >

[PATCH] locking/lockdep: Fix lock IRQ usage initialization bug

2019-06-09 Thread Yuyang Du
The commit: 091806515124b20 ("locking/lockdep: Consolidate lock usage bit initialization") misses marking LOCK_USED flag at IRQ usage initialization when CONFIG_TRACE_IRQFLAGS or CONFIG_PROVE_LOCKING is not defined. Fix it. Reported-by: Qian Cai Signed-off-by: Yuyang Du --- kernel/locking/