Re: [PATCH] llist: Fix missing lockless_dereference()

2015-02-10 Thread Paul E. McKenney
On Tue, Feb 10, 2015 at 12:29:24PM -0500, Peter Hurley wrote: > On 02/10/2015 11:38 AM, Paul E. McKenney wrote: > > On Tue, Feb 10, 2015 at 09:03:50AM -0500, Peter Hurley wrote: > >> On 02/06/2015 09:08 PM, Mathieu Desnoyers wrote: > >>> A lockless_dereference() appears to be missing in llist_del_f

Re: [PATCH] llist: Fix missing lockless_dereference()

2015-02-10 Thread Peter Hurley
On 02/10/2015 11:38 AM, Paul E. McKenney wrote: > On Tue, Feb 10, 2015 at 09:03:50AM -0500, Peter Hurley wrote: >> On 02/06/2015 09:08 PM, Mathieu Desnoyers wrote: >>> A lockless_dereference() appears to be missing in llist_del_first(). >>> It should only matter for Alpha in practice. >>> >>> Signe

Re: [PATCH] llist: Fix missing lockless_dereference()

2015-02-10 Thread Paul E. McKenney
On Tue, Feb 10, 2015 at 09:03:50AM -0500, Peter Hurley wrote: > On 02/06/2015 09:08 PM, Mathieu Desnoyers wrote: > > A lockless_dereference() appears to be missing in llist_del_first(). > > It should only matter for Alpha in practice. > > > > Signed-off-by: Mathieu Desnoyers > > CC: Huang Ying >

Re: [PATCH] llist: Fix missing lockless_dereference()

2015-02-10 Thread Peter Hurley
On 02/06/2015 09:08 PM, Mathieu Desnoyers wrote: > A lockless_dereference() appears to be missing in llist_del_first(). > It should only matter for Alpha in practice. > > Signed-off-by: Mathieu Desnoyers > CC: Huang Ying > CC: Paul McKenney > CC: David Howells > CC: Pranith Kumar > CC: sta...

Re: [PATCH] llist: Fix missing lockless_dereference()

2015-02-10 Thread Michael Cree
On Sun, Feb 08, 2015 at 04:25:46AM +, Mathieu Desnoyers wrote: > > From: "Michael Cree" > > The Alpha kernel is behaving pretty well provided one builds a machine > > specific kernel and UP. When running an SMP kernel some packages > > (most notably the java runtime, but there are a few other

Re: [PATCH] llist: Fix missing lockless_dereference()

2015-02-09 Thread Mathieu Desnoyers
gt; , linux-kernel@vger.kernel.org, "Paul McKenney" > , "David Howells" > , "Pranith Kumar" , > sta...@vger.kernel.org > Sent: Monday, February 9, 2015 8:52:28 PM > Subject: Re: [PATCH] llist: Fix missing lockless_dereference() > > Hi, Mathieu, &g

Re: [PATCH] llist: Fix missing lockless_dereference()

2015-02-09 Thread Huang Ying
on" , "Ivan > > Kokshaysky" , "Matt Turner" > > , "Huang Ying" , > > linux-kernel@vger.kernel.org, "Paul McKenney" , > > "David Howells" , > > "Pranith Kumar" , sta...@vger.kernel.org > > Sent:

Re: [PATCH] llist: Fix missing lockless_dereference()

2015-02-07 Thread Mathieu Desnoyers
> linux-kernel@vger.kernel.org, "Paul McKenney" , > "David Howells" , > "Pranith Kumar" , sta...@vger.kernel.org > Sent: Saturday, February 7, 2015 7:47:29 PM > Subject: Re: [PATCH] llist: Fix missing lockless_dereference() > > On Sat, Fe

Re: [PATCH] llist: Fix missing lockless_dereference()

2015-02-07 Thread Greg KH
On Sun, Feb 08, 2015 at 02:12:04PM +1300, Michael Cree wrote: > On Sun, Feb 08, 2015 at 08:59:41AM +0800, Greg KH wrote: > > On Sun, Feb 08, 2015 at 01:47:29PM +1300, Michael Cree wrote: > > > On Sat, Feb 07, 2015 at 10:30:44PM +, Mathieu Desnoyers wrote: > > > > > On Fri, Feb 06, 2015 at 09:08

Re: [PATCH] llist: Fix missing lockless_dereference()

2015-02-07 Thread Michael Cree
On Sun, Feb 08, 2015 at 08:59:41AM +0800, Greg KH wrote: > On Sun, Feb 08, 2015 at 01:47:29PM +1300, Michael Cree wrote: > > On Sat, Feb 07, 2015 at 10:30:44PM +, Mathieu Desnoyers wrote: > > > > On Fri, Feb 06, 2015 at 09:08:21PM -0500, Mathieu Desnoyers wrote: > > > > > A lockless_dereference

Re: [PATCH] llist: Fix missing lockless_dereference()

2015-02-07 Thread Michael Cree
On Sat, Feb 07, 2015 at 10:30:44PM +, Mathieu Desnoyers wrote: > > On Fri, Feb 06, 2015 at 09:08:21PM -0500, Mathieu Desnoyers wrote: > > > A lockless_dereference() appears to be missing in llist_del_first(). > > > It should only matter for Alpha in practice. What could one anticipate to be th

Re: [PATCH] llist: Fix missing lockless_dereference()

2015-02-07 Thread Greg KH
On Sun, Feb 08, 2015 at 01:47:29PM +1300, Michael Cree wrote: > On Sat, Feb 07, 2015 at 10:30:44PM +, Mathieu Desnoyers wrote: > > > On Fri, Feb 06, 2015 at 09:08:21PM -0500, Mathieu Desnoyers wrote: > > > > A lockless_dereference() appears to be missing in llist_del_first(). > > > > It should

Re: [PATCH] llist: Fix missing lockless_dereference()

2015-02-07 Thread Greg KH
; , linux-kernel@vger.kernel.org, > >> "Paul McKenney" , > >> "David Howells" , "Pranith Kumar" > >> , sta...@vger.kernel.org > >> Sent: Saturday, February 7, 2015 5:16:25 PM > >> Subject: Re: [PATCH] llist: Fix missing l

Re: [PATCH] llist: Fix missing lockless_dereference()

2015-02-07 Thread Matt Turner
avid Howells" , "Pranith Kumar" >> , sta...@vger.kernel.org >> Sent: Saturday, February 7, 2015 5:16:25 PM >> Subject: Re: [PATCH] llist: Fix missing lockless_dereference() >> >> On Fri, Feb 06, 2015 at 09:08:21PM -0500, Mathieu Desnoyers wrote: >> &g

Re: [PATCH] llist: Fix missing lockless_dereference()

2015-02-07 Thread Paul E. McKenney
On Sun, Feb 08, 2015 at 06:16:25AM +0800, Greg KH wrote: > On Fri, Feb 06, 2015 at 09:08:21PM -0500, Mathieu Desnoyers wrote: > > A lockless_dereference() appears to be missing in llist_del_first(). > > It should only matter for Alpha in practice. > > Meta-comment, do we really care about Alpha an

Re: [PATCH] llist: Fix missing lockless_dereference()

2015-02-07 Thread Mathieu Desnoyers
- Original Message - > From: "Greg KH" > To: "Mathieu Desnoyers" > Cc: "Huang Ying" , linux-kernel@vger.kernel.org, "Paul > McKenney" , > "David Howells" , "Pranith Kumar" > , sta...@vger.kernel.org > Sent

Re: [PATCH] llist: Fix missing lockless_dereference()

2015-02-07 Thread Greg KH
On Fri, Feb 06, 2015 at 09:08:21PM -0500, Mathieu Desnoyers wrote: > A lockless_dereference() appears to be missing in llist_del_first(). > It should only matter for Alpha in practice. Meta-comment, do we really care about Alpha anymore? Is it still consered an "active" arch we support? I haven'

[PATCH] llist: Fix missing lockless_dereference()

2015-02-06 Thread Mathieu Desnoyers
A lockless_dereference() appears to be missing in llist_del_first(). It should only matter for Alpha in practice. Signed-off-by: Mathieu Desnoyers CC: Huang Ying CC: Paul McKenney CC: David Howells CC: Pranith Kumar CC: sta...@vger.kernel.org # v3.1+ --- lib/llist.c | 8 +++- 1 file chan