Re: [PATCH] livepatch: match return value to function signature

2015-05-27 Thread Nicholas Mc Guire
On Wed, 27 May 2015, Jiri Slaby wrote: > On 05/27/2015, 08:56 AM, Nicholas Mc Guire wrote: > > On Mon, 11 May 2015, Jiri Slaby wrote: > > > >> On 05/11/2015, 07:52 AM, Nicholas Mc Guire wrote: > >>> klp_initialized() should return bool but is actually returning > >>> struct kobject * - convert i

Re: [PATCH] livepatch: match return value to function signature

2015-05-27 Thread Jiri Slaby
On 05/27/2015, 08:56 AM, Nicholas Mc Guire wrote: > On Mon, 11 May 2015, Jiri Slaby wrote: > >> On 05/11/2015, 07:52 AM, Nicholas Mc Guire wrote: >>> klp_initialized() should return bool but is actually returning >>> struct kobject * - convert it to a boolean explicitly. >>> >>> Signed-off-by: Ni

Re: [PATCH] livepatch: match return value to function signature

2015-05-26 Thread Nicholas Mc Guire
On Mon, 11 May 2015, Jiri Slaby wrote: > On 05/11/2015, 07:52 AM, Nicholas Mc Guire wrote: > > klp_initialized() should return bool but is actually returning > > struct kobject * - convert it to a boolean explicitly. > > > > Signed-off-by: Nicholas Mc Guire > > Reviewed-by: Jiri Slaby > sorry

Re: [PATCH] livepatch: match return value to function signature

2015-05-11 Thread Jiri Kosina
On Mon, 11 May 2015, Nicholas Mc Guire wrote: > klp_initialized() should return bool but is actually returning > struct kobject * - convert it to a boolean explicitly. > > Signed-off-by: Nicholas Mc Guire > --- > > static code checking was not happy with > ./kernel/livepatch/core.c:131 WARNIN

Re: [PATCH] livepatch: match return value to function signature

2015-05-11 Thread Josh Poimboeuf
On Mon, May 11, 2015 at 07:52:29AM +0200, Nicholas Mc Guire wrote: > klp_initialized() should return bool but is actually returning > struct kobject * - convert it to a boolean explicitly. > > Signed-off-by: Nicholas Mc Guire > --- > > static code checking was not happy with > ./kernel/livepat

Re: [PATCH] livepatch: match return value to function signature

2015-05-11 Thread Jiri Slaby
On 05/11/2015, 07:52 AM, Nicholas Mc Guire wrote: > klp_initialized() should return bool but is actually returning > struct kobject * - convert it to a boolean explicitly. > > Signed-off-by: Nicholas Mc Guire Reviewed-by: Jiri Slaby Thanks. > --- > > static code checking was not happy with

[PATCH] livepatch: match return value to function signature

2015-05-10 Thread Nicholas Mc Guire
klp_initialized() should return bool but is actually returning struct kobject * - convert it to a boolean explicitly. Signed-off-by: Nicholas Mc Guire --- static code checking was not happy with ./kernel/livepatch/core.c:131 WARNING: return of wrong type bool !=