Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific

2016-08-25 Thread Josh Poimboeuf
On Thu, Aug 25, 2016 at 04:25:15PM +0200, Miroslav Benes wrote: > On Wed, 24 Aug 2016, Josh Poimboeuf wrote: > > > There's no reliable way to determine which module tainted the kernel > > with CONFIG_LIVEPATCH. For example, /sys/module//taint > > doesn't report it. Neither does the "mod -t" comm

Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific

2016-08-25 Thread Miroslav Benes
On Thu, 25 Aug 2016, Josh Poimboeuf wrote: > On Thu, Aug 25, 2016 at 04:25:15PM +0200, Miroslav Benes wrote: > > On Wed, 24 Aug 2016, Josh Poimboeuf wrote: > > > > > There's no reliable way to determine which module tainted the kernel > > > with CONFIG_LIVEPATCH. For example, /sys/module//taint

Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific

2016-08-25 Thread Miroslav Benes
On Wed, 24 Aug 2016, Josh Poimboeuf wrote: > There's no reliable way to determine which module tainted the kernel > with CONFIG_LIVEPATCH. For example, /sys/module//taint > doesn't report it. Neither does the "mod -t" command in the crash tool. > > Make it crystal clear who the guilty party is

Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific

2016-08-25 Thread Josh Poimboeuf
On Thu, Aug 25, 2016 at 09:46:06AM +0200, Petr Mladek wrote: > Hi, > > I have spent some time to understand the change. I hope that the > comments below would help others. > > On Wed 2016-08-24 16:33:00, Josh Poimboeuf wrote: > > There's no reliable way to determine which module tainted the kerne

Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific

2016-08-25 Thread Rusty Russell
Jiri Kosina writes: > On Wed, 24 Aug 2016, Josh Poimboeuf wrote: > >> There's no reliable way to determine which module tainted the kernel >> with CONFIG_LIVEPATCH. For example, /sys/module//taint >> doesn't report it. Neither does the "mod -t" command in the crash tool. >> >> Make it crystal c

Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific

2016-08-25 Thread Petr Mladek
Hi, I have spent some time to understand the change. I hope that the comments below would help others. On Wed 2016-08-24 16:33:00, Josh Poimboeuf wrote: > There's no reliable way to determine which module tainted the kernel > with CONFIG_LIVEPATCH. For example, /sys/module//taint > doesn't repor

Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific

2016-08-25 Thread Josh Poimboeuf
On Wed, Aug 24, 2016 at 04:33:00PM -0500, Josh Poimboeuf wrote: > There's no reliable way to determine which module tainted the kernel > with CONFIG_LIVEPATCH. For example, /sys/module//taint > doesn't report it. Neither does the "mod -t" command in the crash tool. > > Make it crystal clear who

Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific

2016-08-24 Thread kbuild test robot
Hi Josh, [auto build test ERROR on jikos-livepatching/for-next] [also build test ERROR on v4.8-rc3 next-20160824] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience)

Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific

2016-08-24 Thread Jiri Kosina
On Wed, 24 Aug 2016, Josh Poimboeuf wrote: > There's no reliable way to determine which module tainted the kernel > with CONFIG_LIVEPATCH. For example, /sys/module//taint > doesn't report it. Neither does the "mod -t" command in the crash tool. > > Make it crystal clear who the guilty party is

Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific

2016-08-24 Thread Josh Poimboeuf
On Wed, Aug 24, 2016 at 04:33:00PM -0500, Josh Poimboeuf wrote: > There's no reliable way to determine which module tainted the kernel > with CONFIG_LIVEPATCH. For example, /sys/module//taint > doesn't report it. Neither does the "mod -t" command in the crash tool. > > Make it crystal clear who

[PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific

2016-08-24 Thread Josh Poimboeuf
There's no reliable way to determine which module tainted the kernel with CONFIG_LIVEPATCH. For example, /sys/module//taint doesn't report it. Neither does the "mod -t" command in the crash tool. Make it crystal clear who the guilty party is by converting CONFIG_LIVEPATCH to a module taint flag.