Re: [PATCH] linux/kernel.h: break long lines

2018-02-24 Thread Alexey Dobriyan
> -static inline int __must_check kstrtol(const char *s, unsigned int base, > long *res) > +static inline int __must_check kstrtol(const char *s, unsigned int base, > + long *res) Please find and fix a bug instead of making feel-good changes.

Re: [PATCH] linux/kernel.h: break long lines

2018-02-24 Thread Borislav Petkov
On Sat, Feb 24, 2018 at 01:45:30PM -0500, Theodore Ts'o wrote: > static inline int __must_check > kstrtou64_from_user(const char __user *s, size_t count, unsigned int base, > u64 *res) Yeah, had already typed that one in the reply but then opted for not mentioning it because it is a bit controver

Re: [PATCH] linux/kernel.h: break long lines

2018-02-24 Thread Theodore Ts'o
On Sat, Feb 24, 2018 at 07:30:44PM +0100, Borislav Petkov wrote: > > And, for the record, if we have to break a function signature, we align the > arguments at the opening brace like this: > > static inline int __must_check kstrtou64_from_user(const char __user *s, >

Re: [PATCH] linux/kernel.h: break long lines

2018-02-24 Thread Borislav Petkov
On Sat, Feb 24, 2018 at 03:10:02PM -0300, Gustavo Leite wrote: > Break lines that are longer than 80 characters do match the linux coding > style. > > Signed-off-by: Gustavo Leite > --- > include/linux/kernel.h | 74 > +- > 1 file changed, 49 inse

[PATCH] linux/kernel.h: break long lines

2018-02-24 Thread Gustavo Leite
Break lines that are longer than 80 characters do match the linux coding style. Signed-off-by: Gustavo Leite --- include/linux/kernel.h | 74 +- 1 file changed, 49 insertions(+), 25 deletions(-) diff --git a/include/linux/kernel.h b/include/linux/