Re: [PATCH] linux/compiler-clang.h: define HAVE_BUILTIN_BSWAP*

2021-02-25 Thread Luc Van Oostenryck
On Thu, Feb 25, 2021 at 05:45:09PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > Fixes: 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h mutually > exclusive") > Signed-off-by: Arnd Bergmann > --- > include/linux/compiler-clang.h | 10 ++ > 1 file changed, 10 inserti

Re: [PATCH] linux/compiler-clang.h: define HAVE_BUILTIN_BSWAP*

2021-02-25 Thread Miguel Ojeda
On Thu, Feb 25, 2021 at 9:18 PM Nathan Chancellor wrote: > > Indeed. Any wins that we can get with compile time, we should take. > Clang is being widely used in production systems now so I feel like with > a trivial change plus user visible impact, it should be backported. > > Not to mention that

Re: [PATCH] linux/compiler-clang.h: define HAVE_BUILTIN_BSWAP*

2021-02-25 Thread Miguel Ojeda
On Thu, Feb 25, 2021 at 9:14 PM Kees Cook wrote: > > It's a trivial change, so I think it's worth it? It is simple, but it is not trivial since it may change codegen. Acked-by: Miguel Ojeda Cheers, Miguel

Re: [PATCH] linux/compiler-clang.h: define HAVE_BUILTIN_BSWAP*

2021-02-25 Thread Nick Desaulniers
On Thu, Feb 25, 2021 at 12:06 PM Andrew Morton wrote: > > On Thu, 25 Feb 2021 12:03:48 -0800 Kees Cook wrote: > > > On Thu, Feb 25, 2021 at 05:45:09PM +0100, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > Separating compiler-clang.h from compiler-gcc.h inadventently dropped the > > >

Re: [PATCH] linux/compiler-clang.h: define HAVE_BUILTIN_BSWAP*

2021-02-25 Thread Nathan Chancellor
On Thu, Feb 25, 2021 at 12:14:17PM -0800, Kees Cook wrote: > On Thu, Feb 25, 2021 at 12:06:37PM -0800, Andrew Morton wrote: > > On Thu, 25 Feb 2021 12:03:48 -0800 Kees Cook wrote: > > > > > On Thu, Feb 25, 2021 at 05:45:09PM +0100, Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > > > >

Re: [PATCH] linux/compiler-clang.h: define HAVE_BUILTIN_BSWAP*

2021-02-25 Thread Kees Cook
On Thu, Feb 25, 2021 at 12:06:37PM -0800, Andrew Morton wrote: > On Thu, 25 Feb 2021 12:03:48 -0800 Kees Cook wrote: > > > On Thu, Feb 25, 2021 at 05:45:09PM +0100, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > Separating compiler-clang.h from compiler-gcc.h inadventently dropped t

Re: [PATCH] linux/compiler-clang.h: define HAVE_BUILTIN_BSWAP*

2021-02-25 Thread Andrew Morton
On Thu, 25 Feb 2021 12:03:48 -0800 Kees Cook wrote: > On Thu, Feb 25, 2021 at 05:45:09PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > Separating compiler-clang.h from compiler-gcc.h inadventently dropped the > > definitions of the three HAVE_BUILTIN_BSWAP macros, which requires f

Re: [PATCH] linux/compiler-clang.h: define HAVE_BUILTIN_BSWAP*

2021-02-25 Thread Kees Cook
On Thu, Feb 25, 2021 at 05:45:09PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > Separating compiler-clang.h from compiler-gcc.h inadventently dropped the > definitions of the three HAVE_BUILTIN_BSWAP macros, which requires falling > back to the open-coded version and hoping that the comp

Re: [PATCH] linux/compiler-clang.h: define HAVE_BUILTIN_BSWAP*

2021-02-25 Thread Nathan Chancellor
On Thu, Feb 25, 2021 at 05:45:09PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > Separating compiler-clang.h from compiler-gcc.h inadventently dropped the > definitions of the three HAVE_BUILTIN_BSWAP macros, which requires falling > back to the open-coded version and hoping that the comp

[PATCH] linux/compiler-clang.h: define HAVE_BUILTIN_BSWAP*

2021-02-25 Thread Arnd Bergmann
From: Arnd Bergmann Separating compiler-clang.h from compiler-gcc.h inadventently dropped the definitions of the three HAVE_BUILTIN_BSWAP macros, which requires falling back to the open-coded version and hoping that the compiler detects it. Since all versions of clang support the __builtin_bswap