Re: [PATCH] libata: add parentheses to avoid a gcc warning

2016-07-21 Thread Tom Yan
The commit has been reverted. The parentheses are actually necessary since `!=` is of higher precedence than `&`. My bad. On 21 July 2016 at 15:40, Arnd Bergmann wrote: > gcc-6.1 warns about possibly ambiguous code that was newly added > to libata: > > drivers/ata/libata-scsi.c: In function 'ata_

[PATCH] libata: add parentheses to avoid a gcc warning

2016-07-21 Thread Arnd Bergmann
gcc-6.1 warns about possibly ambiguous code that was newly added to libata: drivers/ata/libata-scsi.c: In function 'ata_mselect_caching': drivers/ata/libata-scsi.c:3637:28: error: suggest parentheses around comparison in operand of '&' [-Werror=parentheses] drivers/ata/libata-scsi.c: In function