RE: [PATCH] libahci: fix turning on LEDs in ahci_start_port()

2013-10-14 Thread Dorau, Lukasz
On Monday, October 14, 2013 3:21 PM Tejun Heo wrote: > On Mon, Oct 14, 2013 at 02:58:19PM +0200, Lukasz Dorau wrote: > > If EM Transmit bit is busy during init ata_msleep() is called. > > It is wrong - msleep() should be used instead of ata_msleep(), because > > if EM Transmit bit is busy for one

Re: [PATCH] libahci: fix turning on LEDs in ahci_start_port()

2013-10-14 Thread Tejun Heo
On Mon, Oct 14, 2013 at 02:58:19PM +0200, Lukasz Dorau wrote: > If EM Transmit bit is busy during init ata_msleep() is called. > It is wrong - msleep() should be used instead of ata_msleep(), > because if EM Transmit bit is busy for one port, it will be busy > for all other ports too, so using ata_

[PATCH] libahci: fix turning on LEDs in ahci_start_port()

2013-10-14 Thread Lukasz Dorau
If EM Transmit bit is busy during init ata_msleep() is called. It is wrong - msleep() should be used instead of ata_msleep(), because if EM Transmit bit is busy for one port, it will be busy for all other ports too, so using ata_msleep() causes wasting tries for another ports. The most common scen