Re: [PATCH] lib: vsprintf: Avoid 32-bit truncation in vsscanf number parsing

2020-11-16 Thread Richard Fitzgerald
On 13/11/2020 14:00, Petr Mladek wrote: On Thu 2020-11-12 12:04:27, Steven Rostedt wrote: On Thu, 12 Nov 2020 15:46:46 + Richard Fitzgerald wrote: See this thread from 2014 where the field width problem was raised and explained: http://lkml.iu.edu/hypermail/linux/kernel/1401.1/03443.html

Re: [PATCH] lib: vsprintf: Avoid 32-bit truncation in vsscanf number parsing

2020-11-13 Thread Petr Mladek
On Thu 2020-11-12 12:04:27, Steven Rostedt wrote: > On Thu, 12 Nov 2020 15:46:46 + > Richard Fitzgerald wrote: > > > See this thread from 2014 where the field width problem was raised and > > explained: > > http://lkml.iu.edu/hypermail/linux/kernel/1401.1/03443.html > > > > and the reply fro

Re: [PATCH] lib: vsprintf: Avoid 32-bit truncation in vsscanf number parsing

2020-11-12 Thread Steven Rostedt
On Thu, 12 Nov 2020 15:46:46 + Richard Fitzgerald wrote: > See this thread from 2014 where the field width problem was raised and > explained: > http://lkml.iu.edu/hypermail/linux/kernel/1401.1/03443.html > > and the reply from Linus Torvalds that was against fixing field width > handling: >

RE: [PATCH] lib: vsprintf: Avoid 32-bit truncation in vsscanf number parsing

2020-11-12 Thread David Laight
From: Petr Mladek > Sent: 12 November 2020 16:18 > > Adding other vsprintf maintainers and reviewes into CC. > > On Thu 2020-11-12 11:17:59, Richard Fitzgerald wrote: > > Number conversion in vsscanf converts a whole string of digits and then > > extracts the field width part from the converted v

Re: [PATCH] lib: vsprintf: Avoid 32-bit truncation in vsscanf number parsing

2020-11-12 Thread Petr Mladek
Adding other vsprintf maintainers and reviewes into CC. On Thu 2020-11-12 11:17:59, Richard Fitzgerald wrote: > Number conversion in vsscanf converts a whole string of digits and then > extracts the field width part from the converted value. The maximum run > of digits is limited by overflow. Conv

Re: [PATCH] lib: vsprintf: Avoid 32-bit truncation in vsscanf number parsing

2020-11-12 Thread Richard Fitzgerald
On 12/11/2020 15:35, Steven Rostedt wrote: On Thu, 12 Nov 2020 11:17:59 + Richard Fitzgerald wrote: Number conversion in vsscanf converts a whole string of digits and then extracts the field width part from the converted value. The maximum run of digits is limited by overflow. Conversion w

Re: [PATCH] lib: vsprintf: Avoid 32-bit truncation in vsscanf number parsing

2020-11-12 Thread Steven Rostedt
On Thu, 12 Nov 2020 11:17:59 + Richard Fitzgerald wrote: > Number conversion in vsscanf converts a whole string of digits and then > extracts the field width part from the converted value. The maximum run > of digits is limited by overflow. Conversion was using either > simple_strto[u]l or si

[PATCH] lib: vsprintf: Avoid 32-bit truncation in vsscanf number parsing

2020-11-12 Thread Richard Fitzgerald
Number conversion in vsscanf converts a whole string of digits and then extracts the field width part from the converted value. The maximum run of digits is limited by overflow. Conversion was using either simple_strto[u]l or simple_strto[u]ll based on the 'L' qualifier. This created a difference i