Re: [PATCH] lib: test_user_copy: style cleanup

2019-10-06 Thread Aleksa Sarai
On 2019-10-06, Christian Brauner wrote: > On Sun, Oct 06, 2019 at 10:30:28AM +1100, Aleksa Sarai wrote: > > While writing the tests for copy_struct_from_user(), I used a construct > > that Linus doesn't appear to be too fond of: > > > > On 2019-10-04, Linus Torvalds wrote: > > > Hmm. That code i

Re: [PATCH] lib: test_user_copy: style cleanup

2019-10-06 Thread Christian Brauner
On Sun, Oct 06, 2019 at 10:30:28AM +1100, Aleksa Sarai wrote: > While writing the tests for copy_struct_from_user(), I used a construct > that Linus doesn't appear to be too fond of: > > On 2019-10-04, Linus Torvalds wrote: > > Hmm. That code is ugly, both before and after the fix. > > > > This j

Re: [PATCH] lib: test_user_copy: style cleanup

2019-10-05 Thread Nathan Chancellor
On Sun, Oct 06, 2019 at 10:30:28AM +1100, Aleksa Sarai wrote: > While writing the tests for copy_struct_from_user(), I used a construct > that Linus doesn't appear to be too fond of: > > On 2019-10-04, Linus Torvalds wrote: > > Hmm. That code is ugly, both before and after the fix. > > > > This j

[PATCH] lib: test_user_copy: style cleanup

2019-10-05 Thread Aleksa Sarai
While writing the tests for copy_struct_from_user(), I used a construct that Linus doesn't appear to be too fond of: On 2019-10-04, Linus Torvalds wrote: > Hmm. That code is ugly, both before and after the fix. > > This just doesn't make sense for so many reasons: > > if ((ret |= test(ume