Re: [PATCH] lib: add basic KUnit test for lib/math

2020-11-02 Thread kernel test robot
Hi Daniel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on 7cf726a59435301046250c42131554d9ccc566b8] url: https://github.com/0day-ci/linux/commits/Daniel-Latypov/lib-add-basic-KUnit-test-for-lib-math/20201020-064737 base:7cf726a59435301046250c42131554d9

Re: [PATCH] lib: add basic KUnit test for lib/math

2020-11-02 Thread kernel test robot
Hi Daniel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on 7cf726a59435301046250c42131554d9ccc566b8] url: https://github.com/0day-ci/linux/commits/Daniel-Latypov/lib-add-basic-KUnit-test-for-lib-math/20201020-064737 base:7cf726a59435301046250c42131554d9

Re: [PATCH] lib: add basic KUnit test for lib/math

2020-10-23 Thread Andy Shevchenko
On Thu, Oct 22, 2020 at 02:21:40PM -0700, Brendan Higgins wrote: > On Thu, Oct 22, 2020 at 12:04 PM Andy Shevchenko > wrote: > > On Thu, Oct 22, 2020 at 11:53:50AM -0700, Brendan Higgins wrote: > > > On Thu, Oct 22, 2020 at 8:06 AM Andy Shevchenko > > > wrote: ... > > Why do we have docs in the

Re: [PATCH] lib: add basic KUnit test for lib/math

2020-10-22 Thread Brendan Higgins
On Thu, Oct 22, 2020 at 12:04 PM Andy Shevchenko wrote: > > On Thu, Oct 22, 2020 at 11:53:50AM -0700, Brendan Higgins wrote: > > On Thu, Oct 22, 2020 at 8:06 AM Andy Shevchenko > > wrote: > > > On Wed, Oct 21, 2020 at 10:47:50AM -0700, Daniel Latypov wrote: > > ... > > > > You need to put detaile

Re: [PATCH] lib: add basic KUnit test for lib/math

2020-10-22 Thread Andy Shevchenko
On Thu, Oct 22, 2020 at 10:10:38PM +0300, Andy Shevchenko wrote: > On Thu, Oct 22, 2020 at 09:26:45AM -0700, Daniel Latypov wrote: > > On Thu, Oct 22, 2020 at 8:06 AM Andy Shevchenko > > wrote: > > > On Wed, Oct 21, 2020 at 10:47:50AM -0700, Daniel Latypov wrote: ... > > > Summarize this, please

Re: [PATCH] lib: add basic KUnit test for lib/math

2020-10-22 Thread Andy Shevchenko
On Thu, Oct 22, 2020 at 09:26:45AM -0700, Daniel Latypov wrote: > On Thu, Oct 22, 2020 at 8:06 AM Andy Shevchenko > wrote: > > On Wed, Oct 21, 2020 at 10:47:50AM -0700, Daniel Latypov wrote: ... > > You need to put detailed comments in the code to have it as real example > > how to > > create t

Re: [PATCH] lib: add basic KUnit test for lib/math

2020-10-22 Thread Andy Shevchenko
On Thu, Oct 22, 2020 at 11:53:50AM -0700, Brendan Higgins wrote: > On Thu, Oct 22, 2020 at 8:06 AM Andy Shevchenko > wrote: > > On Wed, Oct 21, 2020 at 10:47:50AM -0700, Daniel Latypov wrote: ... > > You need to put detailed comments in the code to have it as real example > > how to > > create

Re: [PATCH] lib: add basic KUnit test for lib/math

2020-10-22 Thread Brendan Higgins
On Thu, Oct 22, 2020 at 8:06 AM Andy Shevchenko wrote: > > On Wed, Oct 21, 2020 at 10:47:50AM -0700, Daniel Latypov wrote: > > On Tue, Oct 20, 2020 at 8:40 PM David Gow wrote: > > > On Tue, Oct 20, 2020 at 6:46 AM Daniel Latypov > > > wrote: > > > > > > > > Add basic test coverage for files tha

Re: [PATCH] lib: add basic KUnit test for lib/math

2020-10-22 Thread Brendan Higgins
On Thu, Oct 22, 2020 at 9:26 AM Daniel Latypov wrote: > > On Thu, Oct 22, 2020 at 8:06 AM Andy Shevchenko > wrote: > > > > On Wed, Oct 21, 2020 at 10:47:50AM -0700, Daniel Latypov wrote: > > > On Tue, Oct 20, 2020 at 8:40 PM David Gow wrote: > > > > On Tue, Oct 20, 2020 at 6:46 AM Daniel Latypov

Re: [PATCH] lib: add basic KUnit test for lib/math

2020-10-22 Thread Daniel Latypov
On Thu, Oct 22, 2020 at 8:06 AM Andy Shevchenko wrote: > > On Wed, Oct 21, 2020 at 10:47:50AM -0700, Daniel Latypov wrote: > > On Tue, Oct 20, 2020 at 8:40 PM David Gow wrote: > > > On Tue, Oct 20, 2020 at 6:46 AM Daniel Latypov > > > wrote: > > > > > > > > Add basic test coverage for files tha

Re: [PATCH] lib: add basic KUnit test for lib/math

2020-10-22 Thread Andy Shevchenko
On Wed, Oct 21, 2020 at 10:47:50AM -0700, Daniel Latypov wrote: > On Tue, Oct 20, 2020 at 8:40 PM David Gow wrote: > > On Tue, Oct 20, 2020 at 6:46 AM Daniel Latypov wrote: > > > > > > Add basic test coverage for files that don't require any config options: > > > * gcd.c > > > * lcm.c > > > * int

Re: [PATCH] lib: add basic KUnit test for lib/math

2020-10-21 Thread Daniel Latypov
On Tue, Oct 20, 2020 at 8:40 PM David Gow wrote: > > On Tue, Oct 20, 2020 at 6:46 AM Daniel Latypov wrote: > > > > Add basic test coverage for files that don't require any config options: > > * gcd.c > > * lcm.c > > * int_sqrt.c > > * reciprocal_div.c > > (Ignored int_pow.c since it's a simple te

Re: [PATCH] lib: add basic KUnit test for lib/math

2020-10-20 Thread David Gow
On Tue, Oct 20, 2020 at 6:46 AM Daniel Latypov wrote: > > Add basic test coverage for files that don't require any config options: > * gcd.c > * lcm.c > * int_sqrt.c > * reciprocal_div.c > (Ignored int_pow.c since it's a simple textbook algorithm.) > I don't see a particular reason why int_pow.c b

Re: [PATCH] lib: add basic KUnit test for lib/math

2020-10-20 Thread Daniel Latypov
On Tue, Oct 20, 2020 at 1:08 AM Andy Shevchenko wrote: > > On Mon, Oct 19, 2020 at 03:45:56PM -0700, Daniel Latypov wrote: > > Add basic test coverage for files that don't require any config options: > > * gcd.c > > * lcm.c > > * int_sqrt.c > > * reciprocal_div.c > > (Ignored int_pow.c since it's

Re: [PATCH] lib: add basic KUnit test for lib/math

2020-10-20 Thread Andy Shevchenko
On Mon, Oct 19, 2020 at 03:45:56PM -0700, Daniel Latypov wrote: > Add basic test coverage for files that don't require any config options: > * gcd.c > * lcm.c > * int_sqrt.c > * reciprocal_div.c > (Ignored int_pow.c since it's a simple textbook algorithm.) > > These tests aren't particularly inter

Re: [PATCH] lib: add basic KUnit test for lib/math

2020-10-19 Thread kernel test robot
Hi Daniel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on 7cf726a59435301046250c42131554d9ccc566b8] url: https://github.com/0day-ci/linux/commits/Daniel-Latypov/lib-add-basic-KUnit-test-for-lib-math/20201020-064737 base:7cf726a59435301046250c42131554d9

[PATCH] lib: add basic KUnit test for lib/math

2020-10-19 Thread Daniel Latypov
Add basic test coverage for files that don't require any config options: * gcd.c * lcm.c * int_sqrt.c * reciprocal_div.c (Ignored int_pow.c since it's a simple textbook algorithm.) These tests aren't particularly interesting, but * they're chosen as easy to understand examples of how to write test