Re: [PATCH] lib/scatterlist: Avoid a double memset

2020-09-20 Thread Christophe JAILLET
Le 20/09/2020 à 10:32, Julia Lawall a écrit : On Sun, 20 Sep 2020, Joe Perches wrote: On Sun, 2020-09-20 at 09:15 +0200, Christophe JAILLET wrote: 'sgl' is zeroed a few lines below in 'sg_init_table()'. There is no need to clear it twice. Remove the redundant initialization. I didn't look

Re: [PATCH] lib/scatterlist: Avoid a double memset

2020-09-20 Thread Julia Lawall
On Sun, 20 Sep 2020, Joe Perches wrote: > On Sun, 2020-09-20 at 09:15 +0200, Christophe JAILLET wrote: > > 'sgl' is zeroed a few lines below in 'sg_init_table()'. There is no need to > > clear it twice. > > > > Remove the redundant initialization. > > I didn't look very thoroughly, but there ar

Re: [PATCH] lib/scatterlist: Avoid a double memset

2020-09-20 Thread Joe Perches
On Sun, 2020-09-20 at 09:15 +0200, Christophe JAILLET wrote: > 'sgl' is zeroed a few lines below in 'sg_init_table()'. There is no need to > clear it twice. > > Remove the redundant initialization. I didn't look very thoroughly, but there are at least a few more of these with kcalloc and kzalloc

[PATCH] lib/scatterlist: Avoid a double memset

2020-09-20 Thread Christophe JAILLET
'sgl' is zeroed a few lines below in 'sg_init_table()'. There is no need to clear it twice. Remove the redundant initialization. Signed-off-by: Christophe JAILLET --- lib/scatterlist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/scatterlist.c b/lib/scatterlist.c inde